openbsd/src/lib/libcrypto/dh, branch libressl-v3.9.1A mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=libressl-v3.9.12024-01-04T17:01:26+00:00Replace .pkey_base_id with a .base_method pointer2024-01-04T17:01:26+00:00tb2024-01-04T17:01:26+00:00urn:sha1:9f1cd2582409ac5778c5a0e28dfb77f18d122c98
Every EVP_PKEY_ASN1_METHOD is either an ASN.1 method or an alias.
As such it resolves to an underlying ASN.1 method (in one step).
This information can be stored in a base_method pointer in allusion
to the pkey_base_id, which is the name for the nid (aka pkey_id aka
type) of the underlying method.
For an ASN.1 method, the base method is itself, so the base method
is set as a pointer to itself. For an alias it is of course a pointer
to the underlying method. Then obviously ameth->pkey_base_id is the
same as ameth->base_method->pkey_id, so rework all ASN.1 methods to
follow that.
ok jsing
kill gross whitespace2024-01-01T16:01:48+00:00tb2024-01-01T16:01:48+00:00urn:sha1:e4fbd68db1b791490c43f96946a1bbfcdcacdc35Rework pkey_dh_paramgen()2023-12-28T22:10:33+00:00tb2023-12-28T22:10:33+00:00urn:sha1:21e1a561a34dd3ca9187fdb5a57a025864d3a115
Similar to pkey_rsa_paramgen() this function does some strange dances
with the pkey_gencb and initialization plus missing error checks. Fix
all that and use the idiom established in previous commits.
ok jsing
Rework pkey_dh_keygen()2023-12-28T22:06:41+00:00tb2023-12-28T22:06:41+00:00urn:sha1:f17548a214654a2b6d13345be9dd4218a9a20182
Single exit, fix error checking and hold on to the DH by keeping a
reference. In other words, switch from EVP_PKEY_assign() to using
EVP_PKEY_set1_DH() and free unconditionally in the error path.
ok jsing
Ignore ENGINE at the API boundary2023-11-29T21:35:57+00:00tb2023-11-29T21:35:57+00:00urn:sha1:69bbc5fea4f411f0c0033ecb0fc5126c895ea82a
This removes the remaining ENGINE members from various internal structs
and functions. Any ENGINE passed into a public API is now completely
ignored functions returning an ENGINE always return NULL.
ok jsing
Unifdef OPENSSL_NO_ENGINE in libcrypto2023-11-19T15:46:10+00:00tb2023-11-19T15:46:10+00:00urn:sha1:593d97e74cc873d99aced677883cf55625efe62d
This is mechanical apart from a few manual edits to avoid doubled empty
lines.
ok jsing
fix whitespace2023-08-13T12:09:14+00:00tb2023-08-13T12:09:14+00:00urn:sha1:9ed4ae0e8bb57718bff8370d5629f36660774ee7Drop silly int_ prefix from _free() and _size()2023-08-12T07:59:48+00:00tb2023-08-12T07:59:48+00:00urn:sha1:156606251785f22da3265415907d576d76db2ff6Free {priv,pub}_key before assigning to it2023-08-12T07:50:47+00:00tb2023-08-12T07:50:47+00:00urn:sha1:75d00cb38a793e674ec61e79cfad30c174e5a93c
While it isn't the case for the default implementations, custom DH and DSA
methods could conceivably populate private and public keys, which in turn
would result in leaks in the pub/priv decode methods.
ok jsing
Simplify and unify missing_parameters() for DH and DSA2023-08-12T07:43:48+00:00tb2023-08-12T07:43:48+00:00urn:sha1:ca959b67a4d1cc2713bf6ef88288116f17fcc8cc
ok jsing