openbsd/src/lib/libcrypto/dsa/dsa_ameth.c, branch OPENBSD_7_9A mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_7_92025-05-10T05:54:39+00:00Use err_local.h rather than err.h in most places2025-05-10T05:54:39+00:00tb2025-05-10T05:54:39+00:00urn:sha1:41e8f99dd1625a9f0c80ce9d4383e95b18e85709
ok jsing
Error check X509_ALGOR_set0() in {dsa,ec}_pkey_ctrl()2024-04-13T14:02:51+00:00tb2024-04-13T14:02:51+00:00urn:sha1:ee9a57f6e037b63c151f6e375585b15eb6c8e467
These are four versions of near identical code: PKCS#7 and CMS controls
for DSA and EC. The checks are rather incomplete and should probably be
merged somehow (see the Ed25519 version in ecx_methods(). For now, only
replace X509_ALGOR_set0() with its internal by_nid() version and, while
there, spell NULL correctly.
ok jca
Unwrap a line for consistency with other copy-pasted versions2024-04-13T13:57:54+00:00tb2024-04-13T13:57:54+00:00urn:sha1:e1beeed86504682f8bf3c8289bbfa83b199f5d90Replace .pkey_base_id with a .base_method pointer2024-01-04T17:01:26+00:00tb2024-01-04T17:01:26+00:00urn:sha1:9f1cd2582409ac5778c5a0e28dfb77f18d122c98
Every EVP_PKEY_ASN1_METHOD is either an ASN.1 method or an alias.
As such it resolves to an underlying ASN.1 method (in one step).
This information can be stored in a base_method pointer in allusion
to the pkey_base_id, which is the name for the nid (aka pkey_id aka
type) of the underlying method.
For an ASN.1 method, the base method is itself, so the base method
is set as a pointer to itself. For an alias it is of course a pointer
to the underlying method. Then obviously ameth->pkey_base_id is the
same as ameth->base_method->pkey_id, so rework all ASN.1 methods to
follow that.
ok jsing
Split ameth arrays into individual methods2024-01-04T16:41:56+00:00tb2024-01-04T16:41:56+00:00urn:sha1:b1aedf2a14d9cd341b6b3b19a90343383ec0209f
For some reason DSA, GOST, and RSA had their ASN.1 methods stored in
an array. This is clumsy and the only benefit is that one saves a few
externs in p_lib.c. They were also arranged by ascending NID because
of bsearch() madness.
Split them up and arrange the methods by name, which is much saner
and simpler.
ok jsing
Drop silly int_ prefix from _free() and _size()2023-08-12T07:59:48+00:00tb2023-08-12T07:59:48+00:00urn:sha1:156606251785f22da3265415907d576d76db2ff6Free {priv,pub}_key before assigning to it2023-08-12T07:50:47+00:00tb2023-08-12T07:50:47+00:00urn:sha1:75d00cb38a793e674ec61e79cfad30c174e5a93c
While it isn't the case for the default implementations, custom DH and DSA
methods could conceivably populate private and public keys, which in turn
would result in leaks in the pub/priv decode methods.
ok jsing
Readability tweak for key parameters in DSA2023-08-12T07:46:14+00:00tb2023-08-12T07:46:14+00:00urn:sha1:3ce61e18114b54d6a68b3d52d58caecbb472fe23
ok jsing
Simplify and unify missing_parameters() for DH and DSA2023-08-12T07:43:48+00:00tb2023-08-12T07:43:48+00:00urn:sha1:ca959b67a4d1cc2713bf6ef88288116f17fcc8cc
ok jsing
Improve variable names in {dh,dsa}_{pub,priv}_{de,en}code()2023-08-11T13:57:24+00:00tb2023-08-11T13:57:24+00:00urn:sha1:1d23790aedecd16063a7b5e8eb1b0f7009f81d22
Use aint for the ASN1_INTEGER holding the key and astr for the ASN1_STRING
holding the parameters. This frees up key and params for their DER encoded
versions, matching the naming we use elsewhere much more closely.
ok jsing