openbsd/src/lib/libcrypto/dsa/dsa_key.c, branch OPENBSD_6_8_BASE A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE 2018-11-09T23:45:19+00:00 Initialize priv_key and pub_key on first use instead of at the top. 2018-11-09T23:45:19+00:00 tb 2018-11-09T23:45:19+00:00 urn:sha1:c9310e29e5625d199fa876322e1794805e1f26e2 ok beck jsing mestre unrevert the use of bn_rand_interval(). 2018-11-06T07:02:33+00:00 tb 2018-11-06T07:02:33+00:00 urn:sha1:b1f2fa8da88f8be2fe7d6d9d2b8308537fcfb408 ok beck jsing revert use of bn_rand_interval due to failures with ECDHE and TLS 2018-11-06T02:14:39+00:00 tb 2018-11-06T02:14:39+00:00 urn:sha1:2040275bab908960f255a8c01f793ac41a51b26b Make use of bn_rand_interval() where appropriate. 2018-11-05T23:54:27+00:00 tb 2018-11-05T23:54:27+00:00 urn:sha1:eaddac22ab3166ef515cb4c286c0c3ed322fbe40 ok beck jsing Eliminate a few "} else" branches, a few unneeded NULL checks before 2018-11-05T23:50:05+00:00 tb 2018-11-05T23:50:05+00:00 urn:sha1:8e9f1d9b90e9437962a4af66f58e24dd9fa2c0c7 freeing and indent nearby labels. ok beck jsing Remove two unnecessary BN_FLG_CONSTTIME dances: BN_mod_exp_ct() already 2018-11-05T23:46:16+00:00 tb 2018-11-05T23:46:16+00:00 urn:sha1:d84e997e985b21f7846260ada232d4d74b349e3e takes care of this internally. ok beck jsing Make explicit _ct and _nonct versions of bn_mod_exp funcitons that 2017-01-21T09:38:59+00:00 beck 2017-01-21T09:38:59+00:00 urn:sha1:a0a595cda97de2b217b0582cfa601ee4c746bfce matter for constant time, and make the public interface only used external to the library. This moves us to a model where the important things are constant time versions unless you ask for them not to be, rather than the opposite. I'll continue with this method by method. Add regress tests for same. ok jsing@ Remove flags for disabling constant-time operations. 2016-06-30T02:02:06+00:00 bcook 2016-06-30T02:02:06+00:00 urn:sha1:3ce2fddbbb0fbded19721d5da476dfdfecb1e48b This removes support for DSA_FLAG_NO_EXP_CONSTTIME, DH_FLAG_NO_EXP_CONSTTIME, and RSA_FLAG_NO_CONSTTIME flags, making all of these operations unconditionally constant-time. Based on the original patch by César Pereid. ok beck@ Disable DSA_FLAG_NO_EXP_CONSTTIME, always enable constant-time behavior. 2016-06-21T04:16:53+00:00 bcook 2016-06-21T04:16:53+00:00 urn:sha1:91d6aae7a299dbce8aafae1d671ec0aa14c5511b Improved patch from Cesar Pereida. See https://github.com/libressl-portable/openbsd/pull/61 for more details. ok beck@ None of these need to include <openssl/rand.h> 2014-10-18T17:20:40+00:00 jsing 2014-10-18T17:20:40+00:00 urn:sha1:0bad55f54f7132a386746f23ba4f2d106d115563