openbsd/src/lib/libcrypto/dsa/dsa_key.c, branch OPENBSD_7_9_BASE

Remove unused DSA methods

2024-05-11T06:43:50+00:00

There are no accessors to set them, so this has been involved in a bunch of dead logic ever since we made DSA opaque a few years ago. ok jsing

Inline dsa_builtin_keygen() in DSA_generate_key()

2024-05-10T04:53:55+00:00

ok djm

Make the bn_rand_interval() API a bit more ergonomic

2023-08-03T18:53:56+00:00

Provide bn_rand_in_range() which is a slightly tweaked version of what was previously called bn_rand_range(). The way bn_rand_range() is called in libcrypto, the lower bound is always expressible as a word. In fact, most of the time it is 1, the DH code uses a 2, the MR tests in BPSW use 3 and an exceptinally high number appears in the Tonelli-Shanks implementation where we use 32. Converting these lower bounds to BIGNUMs on the call site is annoying so let bn_rand_interval() do that internally and route that through bn_rand_in_range(). This way we can avoid using BN_sub_word(). Adjust the bn_isqrt() test to use bn_rand_in_range() since that's the only caller that uses actual BIGNUMs as lower bounds. ok jsing

hide symbols in dsa

2023-07-08T14:28:15+00:00

ok tb@

Simplify BIGNUM handling in dsa_builtin_keygen().

2023-01-11T04:35:26+00:00

Rather than having complicated "attempt to reuse" dances, always allocate priv_key/pub_key, then free and assign on success. ok tb@

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Fix whitespace

2022-11-19T06:33:00+00:00

Prepare the move of DSA_SIG, DSA_METHOD and DSA to dsa_locl.h by

2022-01-07T09:35:36+00:00

including the local header where it will be needed. discussed with jsing

Initialize priv_key and pub_key on first use instead of at the top.

2018-11-09T23:45:19+00:00

ok beck jsing mestre

unrevert the use of bn_rand_interval().

2018-11-06T07:02:33+00:00

ok beck jsing