openbsd/src/lib/libcrypto/dsa/dsa_lib.c, branch OPENBSD_7_9

Use err_local.h rather than err.h in most places

2025-05-10T05:54:39+00:00

ok jsing

Use dsa for DSA and dh for DH

2024-03-27T01:49:31+00:00

This unifies variable names and does some other cleanup. Only change in generated assembly is line number changes.

Unify *_up_ref() implementations

2024-03-27T01:22:30+00:00

No need for an inconsistently named local variable and a ternary operator. ok jsing

Ignore ENGINE at the API boundary

2023-11-29T21:35:57+00:00

This removes the remaining ENGINE members from various internal structs and functions. Any ENGINE passed into a public API is now completely ignored functions returning an ENGINE always return NULL. ok jsing

Unifdef OPENSSL_NO_ENGINE in libcrypto

2023-11-19T15:46:10+00:00

This is mechanical apart from a few manual edits to avoid doubled empty lines. ok jsing

Convert {DH,DSA}_new_method() to using calloc()

2023-08-12T06:14:36+00:00

Due to OPENSSL_NO_ENGINE the engine member of dh and dsa is currently uninitialized. As a consequence, {DH,DSA}_get0_engine() will return a garbage pointer, which is particularly bad because the only reason we kept them in the first place is that they are used by some software... A side effect of freeing with {DH,DSA}_free() instead of a hand-rolled version is that we may call ->meth->finish() before ->meth->init() was called. We need a NULL check for ->meth to be on the safe side in case we should need to bring ENGINE back. with nits from djm ok deraadt djm

hide symbols in dsa

2023-07-08T14:28:15+00:00

ok tb@

Fix an off-by-one in dsa_check_key()

2023-03-11T15:29:03+00:00

The private key is a random number in [1, q-1], so 1 must be allowed. Since q is at least an 160-bit prime and 2^159 + 1 is not prime (159 is not a power of 2), the probability that this is hit is < 2^-159, but a tiny little bit wrong is still wrong. Found while investigating a report by bluhm ok jsing

Call BN_free() instead of BN_clear_free().

2023-03-07T09:27:10+00:00

BN_clear_free() is a wrapper that calls BN_free() - call BN_free() directly instead. ok tb@

Provide dsa_check_key()

2023-03-04T20:54:52+00:00

This is a cheap check that ensures basid parameter consistency per FIPS 186-4: 1 < g < q, that q has the allowed bit sizes 160, 224, 256 and that p is neither too small nor too large. Unfortunately, enforcing the three allowed sizes for p is not possible since the default dsa key generation has not respected this limitation. Instead of checking that p and q are prime, we only check that they are odd. Check that public and private keys, if set, are in the proper range. In particular, disallow zero values. Various versions of these checks have been added to the dsa code over time. This consolidates and extends them and in a subsequent commit wewill replace the incomplete checks. BoringSSL has a similar function of the same name, thanks to David Benjamin for pointing it out. ok beck jsing