openbsd/src/lib/libcrypto/dsa, branch libressl-v2.0.6 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v2.0.6 2014-08-08T05:06:58+00:00 This commit was manufactured by cvs2git to create branch 'OPENBSD_5_6'. 2014-08-08T05:06:58+00:00 cvs2svn admin@example.com 2014-08-08T05:06:58+00:00 urn:sha1:9033820a64c84908dee3f9261ad212f6b6c3449a dsa_priv_decode(): only destroy the object we've created, and with the 2014-07-13T12:45:01+00:00 miod 2014-07-13T12:45:01+00:00 urn:sha1:69cb67782e697a48753f8a3b9d81b89e72aa6ec0 appropriate function. Checking for privkey != NULL is not enough since privkey points to a member of ndsa if ndsa != NULL. dsa_priv_encode(): possible double free in error path. if (x) FOO_free(x) -> FOO_free(x). 2014-07-12T16:03:37+00:00 miod 2014-07-12T16:03:37+00:00 urn:sha1:068bf464df6ef084067943863d776f59762bfaf0 Improves readability, keeps the code smaller so that it is warmer in your cache. review & ok deraadt@ Only import cryptlib.h in the four source files that actually need it. 2014-07-11T08:44:49+00:00 jsing 2014-07-11T08:44:49+00:00 urn:sha1:74e2c009c83ad374bd6acdcfc376a384e25ab007 Remove the openssl public includes from cryptlib.h and add a small number of includes into the source files that actually need them. While here, also sort/group/tidy the includes. ok beck@ miod@ Explicitly include <openssl/opensslconf.h> in every file that references 2014-07-10T22:45:58+00:00 jsing 2014-07-10T22:45:58+00:00 urn:sha1:62348213609ef233110561d1a6ed67ad66df1c7e an OPENSSL_NO_* define. This avoids relying on something else pulling it in for us, plus it fixes several cases where the #ifndef OPENSSL_NO_XYZ is never going to do anything, since OPENSSL_NO_XYZ will never defined, due to the fact that opensslconf.h has not been included. This also includes some miscellaneous sorting/tidying of headers. Stop including standard headers via cryptlib.h - pull in the headers that 2014-07-10T13:58:23+00:00 jsing 2014-07-10T13:58:23+00:00 urn:sha1:c917c683bc93c68fbf4310ac181f7906e76b3c94 are needed in the source files that actually require them. ok beck@ miod@ ASN1_STRING_free can handle NULL, so callers don't need to check. ok miod 2014-07-09T22:55:17+00:00 tedu 2014-07-09T22:55:17+00:00 urn:sha1:00639bfe4c41e004696976f685b376893b255e1a remove unused, private version strings except SSL_version_str 2014-07-09T11:10:51+00:00 bcook 2014-07-09T11:10:51+00:00 urn:sha1:0563b5d49da5a96960925938b3e4f3152e6f5c92 Also remove unused des_ver.h, which exports some of these strings, but is not installed. ok miod@ tedu@ Make use of this wonderful modern C construct known as a `switch', instead of 2014-07-09T11:08:31+00:00 miod 2014-07-09T11:08:31+00:00 urn:sha1:dcbbcd5e23d32dde13dc88631bb224cb81a153da 8-line if() tests. KNF 2014-07-09T10:16:24+00:00 miod 2014-07-09T10:16:24+00:00 urn:sha1:8d28b2bf57f7e00739466371d21495941076bf89