openbsd/src/lib/libcrypto/dsa, branch libressl-v3.8.0

Wire up truncated SHA-2, SHA-3 and related things

2023-04-25T15:48:48+00:00

from jsing

Bring includes into canonical order

2023-04-18T08:47:28+00:00

Requested by jsing

Move some includes out of OPENSSL_NO_DEPRECATED

2023-04-18T08:33:43+00:00

Some headers were included conditionally on OPENSSL_NO_DEPRECATED in hopes that eventually the mess of everything includes everything will magically resolve itself. Of course everyone would end up building openssl with OPENSSL_NO_DEPRECATED over time... Right. Surprisingly, the ecosystem has come to rely on these implicit inclusions, so about two dozen ports would fail to build because of this. Patching this would be easy but really not worth the effort. ok jsing

Remove files that definitely contain no code anymore

2023-04-13T15:04:19+00:00

(experts disagree whether they ever did)

Move DSA_generate_parameters() from dsa_depr.c to dsa_gen.c

2023-04-13T14:58:27+00:00

Discussed with jsing

Move a few functions out of OPENSSL_NO_DEPRECATED

2023-04-09T19:10:23+00:00

Geoff Thorpe added OPENSSL_NO_DEPRECATED nearly two decades ago. The hope was that at some point some functions can be dropped. Most of the functions marked deprecated are actually unused nowadays but unfortunately some of them are still used in the ecosystem. Move them out of OPENSSL_NO_DEPRECATED so we can define it without breaking the consumers in the next bump. ERR_remove_state() is still used by a dozen or so ports. This isn't a big deal since it is just a stupid wrapper for the not quite as deprecated ERR_remove_thread_state(). It's not worth patching these ports. Annoyingly, {DH,DSA}_generate_parameters() and RSA_generate_key() are still used. They "make use" of the old-style BN_GENCB callback, which is therefore more difficult to remove - in case you don't know know: that's the thing responsible for printing pretty '.', '+' and '*' when you generate keys. Most annoyingly, DH_generate_parameters() was added to rust-openssl in 2020 for "advanced DH support". This is very unfortunate since cargo bundles a rust-openssl and updates it only every few years or so. As a consequence we're going to be stuck with this nonsense for a good while. ok beck jsing

Replace the remaining BN_copy() with bn_copy()

2023-03-27T10:25:02+00:00

ok jsing

BN_free() is defined in

2023-03-25T09:09:28+00:00

This is currently pulled in via dsa.h and ecdsa.h, but only when OPENSSL_NO_DEPRECATED is not defined. We should fix this in the public header, too - let's wait a bit with that.

Fix an off-by-one in dsa_check_key()

2023-03-11T15:29:03+00:00

The private key is a random number in [1, q-1], so 1 must be allowed. Since q is at least an 160-bit prime and 2^159 + 1 is not prime (159 is not a power of 2), the probability that this is hit is < 2^-159, but a tiny little bit wrong is still wrong. Found while investigating a report by bluhm ok jsing

Call BN_free() instead of BN_clear_free().

2023-03-07T09:27:10+00:00

BN_clear_free() is a wrapper that calls BN_free() - call BN_free() directly instead. ok tb@