openbsd/src/lib/libcrypto/ec/ec2_oct.c, branch OPENBSD_6_8_BASEA mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE2018-07-15T16:27:39+00:00recommit label indentation part of the backout; clearly unrelated to the2018-07-15T16:27:39+00:00tb2018-07-15T16:27:39+00:00urn:sha1:e2da96a71555180892d2e924d66c06a17b7a86e5
breakage.
back out ecc constant time changes2018-07-15T05:38:48+00:00jsg2018-07-15T05:38:48+00:00urn:sha1:ccbfd1fe05749d4f08db7f45fe5db1fac8d14d6b
after the constant time commits various regress tests started failing
on sparc64 ssh t9, libcrypto ec ecdh ecdsa and trying to ssh out
resulted in 'invalid elliptic curve value'
ok tb@
Indent labels by a space so they don't obliterate function names in diffs.2018-07-10T22:06:14+00:00tb2018-07-10T22:06:14+00:00urn:sha1:a7fe13b565d141da544ee36178a90bb52f4939d1Send the function codes from the error functions to the bit bucket,2017-01-29T17:49:23+00:00beck2017-01-29T17:49:23+00:00urn:sha1:d1f47bd292f36094480caa49ada36b99a69c59b0
as was done earlier in libssl. Thanks inoguchi@ for noticing
libssl had more reacharounds into this.
ok jsing@ inoguchi@
BN_CTX_get() can fail - consistently check its return value.2015-02-09T15:49:22+00:00jsing2015-02-09T15:49:22+00:00urn:sha1:15dc63f9715f4f10924a705d6a4cc564afe2129e
There are currently cases where the return from each call is checked,
the return from only the last call is checked and cases where it is not
checked at all (including code in bn, ec and engine).
Checking the last return value is valid as once the function fails it will
continue to return NULL. However, in order to be consistent check each
call with the same idiom. This makes it easy to verify.
Note there are still a handful of cases that do not follow the idiom -
these will be handled separately.
ok beck@ doug@
Use `> 0' instead of `!= 0' as a successful condition for2015-02-08T22:25:03+00:00miod2015-02-08T22:25:03+00:00urn:sha1:6f9f33882d30bbe9a307e44c69c4f3e22302b332
EC_POINT_is_at_infinity() and EC_POINT_is_on_curve(), for they may return -1
should an error arise.
ok doug@ jsing@
if (x) FOO_free(x) -> FOO_free(x).2014-07-12T16:03:37+00:00miod2014-07-12T16:03:37+00:00urn:sha1:068bf464df6ef084067943863d776f59762bfaf0
Improves readability, keeps the code smaller so that it is warmer in your
cache.
review & ok deraadt@
Explicitly include <openssl/opensslconf.h> in every file that references2014-07-10T22:45:58+00:00jsing2014-07-10T22:45:58+00:00urn:sha1:62348213609ef233110561d1a6ed67ad66df1c7e
an OPENSSL_NO_* define. This avoids relying on something else pulling it
in for us, plus it fixes several cases where the #ifndef OPENSSL_NO_XYZ is
never going to do anything, since OPENSSL_NO_XYZ will never defined, due
to the fact that opensslconf.h has not been included.
This also includes some miscellaneous sorting/tidying of headers.
tags as requested by miod and tedu2014-06-12T15:49:31+00:00deraadt2014-06-12T15:49:31+00:00urn:sha1:59f4f2c61d71e266d37dd2fc97615b3fd35b4721knf approximation2014-05-06T03:56:27+00:00tedu2014-05-06T03:56:27+00:00urn:sha1:c2b0a5b291b1d1b64627e62f53d37965185d466f