openbsd/src/lib/libcrypto/ec/ec_asn1.c, branch OPENBSD_7_9

Use err_local.h rather than err.h in most places

2025-05-10T05:54:39+00:00

ok jsing

Simplify field and private key encoding

2025-03-13T10:31:12+00:00

Reach into the group (p and order are always available) and use BN_num_bytes() rather than using clumsy and badly named API. It's shorter and more readable. ok jsing

Simplify ec_asn1_group2fieldid()

2025-01-25T10:27:58+00:00

The field_type is always NID_X9_62_prime_field, no need to encode and retrieve this from the group method. ok jsing

ec_asn1: update a comment to match reality

2024-12-06T05:13:35+00:00

Set nid on group decoded from EC parameters

2024-12-06T04:35:03+00:00

We match curve parameters against the builtin curves and only accept them if they're encoding a curve known to us. After getting rid of the wtls curves, some of which used to coincide with secp curves (sometimes the wrong ones), the nid is unambiguous. Setting the nid has no direct implications on the encoding. This helps ssh avoid doing ugly computations during the key exchange for PEM keys using this encoding. ok djm joshua jsing

Use OPENSSL_EC_EXPLICIT_CURVE rather than 0

2024-11-22T12:01:14+00:00

Relocate ECParameters_dup() to ec_asn1

2024-11-08T13:55:45+00:00

jsing rightly points out that this has nothing to do with ASN.1, but ec_lib.c has no EC_KEY knowledge otherwise (it's about groups and points) and moving it to ec_key.c is also not satisfactory since the weird d2i/i2d for ECParameters don't belong there either. no objection from jsing

d2i_ECPKParameters(): unify return statement with rest of file

2024-11-02T19:21:24+00:00

Clean up the mess in i2d_EC_PRIVATEKEY()

2024-10-31T15:26:05+00:00

Use a few local variables to make the checks at the start slightly less unappealing. Use those to simplify the conditionals a bit and avoid a particularly silly exit code. ok is set unless ret is 0, so what do you think 'return (ok ? ret : 0);' returns? By the way, ret < 0 is an error as well. While most of the stuff in this file could use a lot more cleanup, I think the first layer of cockroaches has been exterminated and there's even some faint golden glimmer between the turds. Let's shelve the biohazard warnings for now. ok jsing

Clean up o2i_ECPublicKey()

2024-10-31T15:07:49+00:00

a is a stupid name for an EC_key, so is ret. Pull apart the tests at the start and check the length for negativity (long is always the wrong type). Switch to ec_point_from_octets() and let it determine the point conversion form rather than having yet another copy of the same ugly stanza. Set the form on the key using EC_KEY_set_conv_form() (which also affects the group on the key, so this is a slight change of behavior). Why on earth this function returns the EC_KEY passed in, I'll never know. ok jsing