openbsd/src/lib/libcrypto/ec/ec_curve.c, branch OPENBSD_7_9 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_9 2025-12-15T12:09:46+00:00 BN_get_word(): return (BN_ULONG)-1 on error rather than BN_MASK2 2025-12-15T12:09:46+00:00 tb 2025-12-15T12:09:46+00:00 urn:sha1:341829195e0c845cf26339768f275f021b69fedc While the latter is more general in that it also works on 1-complement achitectures, we don't care about that. Adjust documentation and the only error check for it in libcrypto. ok deraadt ec_curve: Remove outdated credits 2025-11-02T13:06:30+00:00 tb 2025-11-02T13:06:30+00:00 urn:sha1:9526f78f99c5585a0ce13e1b7e16523bfa2912e3 Use err_local.h rather than err.h in most places 2025-05-10T05:54:39+00:00 tb 2025-05-10T05:54:39+00:00 urn:sha1:41e8f99dd1625a9f0c80ce9d4383e95b18e85709 ok jsing Remove the X9.62 prime239v{1,2,3} curves 2025-05-04T05:10:14+00:00 tb 2025-05-04T05:10:14+00:00 urn:sha1:08bcfcbc2c4b233a4604e2f883624f517d4bb468 While RFC 3279 allows these curves for use in X.509 certificates (*), no one actually does this. Certs using these curves cannot be used for TLS and the curves aren't accepted by FIPS either. codesearch shows no actual uses of these curves, only their OIDs are listed. At this point these have become useless historical baggage. ok jsing (*) Of the 27 curves listed in RFC 3279 the only one that seems to have seen actual use in certificates is P-256. Move P-256 where it belongs 2025-05-04T04:57:48+00:00 tb 2025-05-04T04:57:48+00:00 urn:sha1:9eefb121b4e4d197efbee12abf51a802d27cb503 ok jsing Fix typo in curve comment: P224r2 -> P224t1 2025-05-03T10:15:50+00:00 tb 2025-05-03T10:15:50+00:00 urn:sha1:e0fe67507db9396f5f4a8944eea9e6ca5a239094 Disambiguate curve comments 2025-03-09T17:53:11+00:00 tb 2025-03-09T17:53:11+00:00 urn:sha1:c7dcb1bd37246960fb73fc82d90f6ccf1543d70b There are three "X9.62 curve over a 239 bit prime field" and the Brainpool curves are a pair for each field size thanks to their characteristic twist. Just include the curve name for each of the curves. discussed with jsing Remove disabled code supporting elliptic curves of small order 2024-12-24T18:33:24+00:00 tb 2024-12-24T18:33:24+00:00 urn:sha1:1703eeacd022ea19c47f102a855bc9ba8ac8d9a3 ok jsing Set nid on group decoded from EC parameters 2024-12-06T04:35:03+00:00 tb 2024-12-06T04:35:03+00:00 urn:sha1:ec50a547d57fc5452ee5d0fe83af3f5b8dfecf79 We match curve parameters against the builtin curves and only accept them if they're encoding a curve known to us. After getting rid of the wtls curves, some of which used to coincide with secp curves (sometimes the wrong ones), the nid is unambiguous. Setting the nid has no direct implications on the encoding. This helps ssh avoid doing ugly computations during the key exchange for PEM keys using this encoding. ok djm joshua jsing Annotate WTLS7 as being wrong 2024-12-04T09:50:52+00:00 tb 2024-12-04T09:50:52+00:00 urn:sha1:703bddb95d0d05878d0df6fcb67913f30f9dfabe This should really have been using SECP 160R2, not SECP 160R1. Of course this means in particular that nobody ever used this curve, at least not against another implementation than OpenSSL. Quasi-monocultures are poisonous whether the monopolist is benevolent and competent or not.