A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v3.9.2 2024-01-04T17:01:26+00:00 2024-01-04T17:01:26+00:00 tb 2024-01-04T17:01:26+00:00 urn:sha1:9f1cd2582409ac5778c5a0e28dfb77f18d122c98 Every EVP_PKEY_ASN1_METHOD is either an ASN.1 method or an alias. As such it resolves to an underlying ASN.1 method (in one step). This information can be stored in a base_method pointer in allusion to the pkey_base_id, which is the name for the nid (aka pkey_id aka type) of the underlying method. For an ASN.1 method, the base method is itself, so the base method is set as a pointer to itself. For an alias it is of course a pointer to the underlying method. Then obviously ameth->pkey_base_id is the same as ameth->base_method->pkey_id, so rework all ASN.1 methods to follow that. ok jsing 2023-12-29T18:49:06+00:00 tb 2023-12-29T18:49:06+00:00 urn:sha1:e50518a9a1aa677e1d49d4309c8e4d4d9be0454e ok jsing 2023-12-29T18:48:25+00:00 tb 2023-12-29T18:48:25+00:00 urn:sha1:3262e60f08c7a7c0605da1f73e684c0ff6a43c4c As per usual. Stylistic adjustments and missing error check. ok jsing 2023-12-29T18:47:47+00:00 tb 2023-12-29T18:47:47+00:00 urn:sha1:3b9ef26e3354193b8139f526e3350d30b751d1f9 This aligns eckey's parameter decoding routine with the one of other cipher abstractions: better variable names, single exit and add missing check for EVP_PKEY_assign_EC_KEY(). ok jsing 2023-12-29T18:46:24+00:00 tb 2023-12-29T18:46:24+00:00 urn:sha1:daac9ac8c298b481db05bf3ee249b871385f2a4d Factor out the pubkey computation and bring it into more sensible form. This removes lots of pointless setting of errors (twice) and makes the code a bit easier on the eyes. Other than that perform some stylistic cleanup like single exit and add an error check for EVP_PKEY_assign(). ok jsing 2023-12-29T18:45:39+00:00 tb 2023-12-29T18:45:39+00:00 urn:sha1:5218d2b40b3ebc8e390ec1c40a2323ecf21637dd 2023-12-28T22:12:37+00:00 tb 2023-12-28T22:12:37+00:00 urn:sha1:9b9639b4856edf75d560e1fd5e1c572614e608da This is basically the same as the dh and dsa version, except it's different because it's EC. Single exit, uniform error checking. "Plug" another leak. With this I earned another shining turd for my collection. ok jsing 2023-12-28T22:09:10+00:00 tb 2023-12-28T22:09:10+00:00 urn:sha1:1707467999f37bd7855f698bf94befe0b33c1a53 The EC code came later, and people got better at writing terrible code. In this case, they could remain quite close to what they copy-pasted from DH, so it was relatively straightforward (for once). There's only one slight extra twist and that's easily dealt with. ok jsing 2023-11-29T21:35:57+00:00 tb 2023-11-29T21:35:57+00:00 urn:sha1:69bbc5fea4f411f0c0033ecb0fc5126c895ea82a This removes the remaining ENGINE members from various internal structs and functions. Any ENGINE passed into a public API is now completely ignored functions returning an ENGINE always return NULL. ok jsing 2023-11-21T22:17:15+00:00 tb 2023-11-21T22:17:15+00:00 urn:sha1:d70ee69e488e1db0b2efc252f1a6959943bfcacc