openbsd/src/lib/libcrypto/ecdh/ecdh.c, branch OPENBSD_7_9

libcrypto: prefix EC_KEY methods with ec_key_

2026-03-18T08:02:40+00:00

We received reports that the too generic internal ecdsa_{sign,verify}() symbol names clash in some static links. The naming here is annoying because the EC_KEY_METHOD amalgamated the no longer existing ECDH and ECDSA methods which themselves had poorly chosen method names, still reflected in public API. There are various messes here. The ECDSA verify methods are declared in ec_local.h, whereas the ECDSA sign methods are in ecdsa_local.h (which is itself pretty useless and really only about EC_KEY_METHOD). I therefore merged the ECDSA method declarations into ec_local.h and deleted ecdsa_local.h since I see no real benefit to the latter. ecdsa.c needs ec_local.h anyway. Having the method declarations next to EC_KEY_METHOD seems sensible. I left the order as it was, matching ecdsa.c. The eckey_compute_pubkey() prototype should probably be moved down. With one exception I just added an ec_key_ prefix. This leads to a a repetition of 'key' in ec_key_ecdh_compute_key() which I chose to live with because it matches the public ECDH_compute_key() (mostly used by SSH implementations). The exception is ec_key_generate_key() where I expanded the gen() leading to another _key repetition but this then matches EC_KEY_generate_key(). Thanks to Rosen Penev for reporting and sending an initial diff. See also https://github.com/gsliepen/tinc/issues/478 ok jsing

Use err_local.h rather than err.h in most places

2025-05-10T05:54:39+00:00

ok jsing

Simplify ECDH_size() by using BN_num_bytes()

2025-02-17T09:25:45+00:00

ok jsing

Remove some unneeded includes from ecdh.c

2023-07-28T09:31:21+00:00

Pull up zeroing of out; drop unnecessary check

2023-07-28T09:30:22+00:00

Move the zeroing of the output buffer a few lines up and remove an unnecessary check. requested/ok jsing

Rename buflen to buf_len, use calloc/freezero

2023-07-28T09:29:24+00:00

Some cosmetic tweaks in ecdh_compute_key(). Rename buflen to buf_len to match out_len, use calloc() and freezero(). ok jsing

Move KDF handling to ECDH_compute_key()

2023-07-28T09:28:37+00:00

In OpenSSL e2285d87, the KDF handling was moved from the compute_key() method into the public API. A consequence of this change is that the ECDH_compute_key() API no longer returns -1 for some errors. Existing checks for <= 0 are safe as are those checking for the exact length as return value, which is all what the ecosystem seems to be doing. ok jsing

Fix two EC_POINT_is_on_curve() checks

2023-07-24T17:08:53+00:00

This API can fail for various reasons, in which case it returns -1, so you need to check if (EC_POINT_is_on_curve_checks(...) <= 0). ok miod

Revert accidental addition of cofactor ECDH support

2023-07-12T08:54:18+00:00

This snuck in with ech_key.c r1.33 because I committed from a dirty tree.

Hide symbols in hkdf, evp, err, ecdsa, and ec

2023-07-07T13:54:46+00:00

(part 2 of commit) ok jsing@