openbsd/src/lib/libcrypto/ecdsa, branch OPENBSD_7_1_BASE A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_1_BASE 2022-04-07T17:37:25+00:00 Avoid infinite loop for custom curves of order 1 2022-04-07T17:37:25+00:00 tb 2022-04-07T17:37:25+00:00 urn:sha1:1061feec63ce8eec5e559ca2697b80bc73044484 If a private key encoded with EC parameters happens to have order 1 and is used for ECDSA signatures, this causes an infinite loop since a random integer x in the interval [0,1) will be 0, so do ... while (x == 0); will loop indefinitely. Found and reported with a reproducer by Hanno Boeck. Helpful comments and analysis from David Benjamin. ok beck jsing sort includes as usual 2022-01-27T20:31:21+00:00 tb 2022-01-27T20:31:21+00:00 urn:sha1:deee88ee0cd8767dc6fd02a8e0977c94dab95b6e Do not depend on engine.h pulling in err.h and evp.h 2022-01-27T20:30:29+00:00 tb 2022-01-27T20:30:29+00:00 urn:sha1:b5eac41199b40cfe298ade9db0b352a6fb470240 Fix check for BN_mod_inverse_ct return value 2022-01-20T11:12:14+00:00 inoguchi 2022-01-20T11:12:14+00:00 urn:sha1:1ca471b8e14d63d9b7059b86938ef989ff0857db ok jsing@ millert@ tb@ Move ECDSA_SIG to ecs_locl.h 2022-01-14T08:31:03+00:00 tb 2022-01-14T08:31:03+00:00 urn:sha1:61219b77d5b56d0f4d1297df47aac4c8a542dbeb We can't make ECDSA_METHOD opaque since it is still used in smtpd(8) ok inoguchi jsing Unifdef LIBRESSL_OPAQUE_* and LIBRESSL_NEXT_API 2022-01-14T07:49:49+00:00 tb 2022-01-14T07:49:49+00:00 urn:sha1:82ec18edf4e632f36b6f79c239fdb6961d421a82 This marks the start of major surgery in libcrypto. Do not attempt to build the tree for a while (~50 commits). Prepare to provide ECDSA_SIG_get0_{r,s}() 2022-01-05T20:39:04+00:00 tb 2022-01-05T20:39:04+00:00 urn:sha1:3fdeff6a8c35a019be65a98554644ca501c8da16 ok inoguchi jsing Add #include "bn_lcl.h" to the files that will soon need it. 2021-12-04T16:08:32+00:00 tb 2021-12-04T16:08:32+00:00 urn:sha1:57082c28039cc632468182b73bebd65a224cbf9d ok inoguchi jsing Simplify code after adding EC_POINT_{s,g}et_affine_coordinates() 2021-04-20T17:23:37+00:00 tb 2021-04-20T17:23:37+00:00 urn:sha1:51b396b145b6146bbdaac4d315068130e31179df ok jsing Prepare to provide EC_POINT_{g,s}et_affine_coordinates 2021-04-20T17:16:38+00:00 tb 2021-04-20T17:16:38+00:00 urn:sha1:d75ea39a8c50b617300b7a60e480697c35a01086 Similar to part of OpenSSL commit 8e3cced75fb5fee5da59ebef9605d403a999391b ok jsing