openbsd/src/lib/libcrypto/err/err.c, branch OPENBSD_7_9_BASE A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_9_BASE 2025-06-10T08:53:37+00:00 err.c: fix previous: 8 spaces -> tab 2025-06-10T08:53:37+00:00 tb 2025-06-10T08:53:37+00:00 urn:sha1:f3cabbdbec3a5f12dc2412a1ecbe3d554cc72588 correct indentation, no functional change 2025-06-02T12:18:22+00:00 jsg 2025-06-02T12:18:22+00:00 urn:sha1:0a9ae15841c7f994ec48b5317b89dbfe586ddcc7 found with smatch, ok tb@ Simplify err_build_SYS_str_reasons 2025-05-20T09:25:40+00:00 tb 2025-05-20T09:25:40+00:00 urn:sha1:acfb6b93a44b615298cbdd3e308e18d0699190e8 This is currently done in a rather silly way. Shift the index by 1 and avoid weird pointer dances. Rather than relying on static initialization, use code to obviate a comment. ok beck joshua jsing Assert assumption on CRYPTO_THREADID 2024-11-02T12:46:36+00:00 tb 2024-11-02T12:46:36+00:00 urn:sha1:18d63435aab73597d2a0cd7bef349030489065b9 This type has been opaque for a while, and nobody should be able to call this function with id != NULL. If they do, we want to know and it should be noisy. suggested by/ok jsing Inline last uses of CRYPTO_THREADID in err/ 2024-11-02T08:54:40+00:00 tb 2024-11-02T08:54:40+00:00 urn:sha1:4189cdb071f900e952175558138d12e220b66514 This is another Thorpian obfuscation scheme hiding nasty casts of pthread_t to unsigned long and comparing them. We can do this in a less underhanded way by calling the portable functions directly. ok jsing err.c: zap stray space 2024-10-11T13:32:22+00:00 tb 2024-10-11T13:32:22+00:00 urn:sha1:b54f6f5ac0019580ccc0312b54fc7b91a61698c5 Apply some style(9) and tidy some comments. 2024-10-11T12:40:25+00:00 jsing 2024-10-11T12:40:25+00:00 urn:sha1:b82588e1fe514eeb47cd772278ef0695046460d0 Remove pointless locking from err_build_SYS_str_reasons(). 2024-10-11T12:27:24+00:00 jsing 2024-10-11T12:27:24+00:00 urn:sha1:08a0fc6106e3b865865a17f29840c44004535ce3 err_build_SYS_str_reasons() is only called during initialisation, under pthread_once(). As such, there is no need to grab CRYPTO_LOCK_ERR or check for reentrant calls. ok tb@ Convert err_clear_data() and err_clear() from macros to functions. 2024-10-11T12:25:05+00:00 jsing 2024-10-11T12:25:05+00:00 urn:sha1:414f7c4d1d08dddf9f974112cd59112e83a5dfb4 ok tb@ Remove unused typedef for ERR_FNS. 2024-10-11T12:20:06+00:00 jsing 2024-10-11T12:20:06+00:00 urn:sha1:94855340006abd70a2b21020511dd2f3e58ff14b