A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_6 2024-08-31T10:09:15+00:00 2024-08-31T10:09:15+00:00 tb 2024-08-31T10:09:15+00:00 urn:sha1:20621a3f421681dddbebb1b41d980374765a0b0e Another unused bit of legacy API... ok beck jsing 2024-07-09T07:17:13+00:00 beck 2024-07-09T07:17:13+00:00 urn:sha1:a09a0ff7b6568c0cf4e6dc355ac218984899ebc3 ok tb@ 2024-06-24T06:43:23+00:00 tb 2024-06-24T06:43:23+00:00 urn:sha1:c9802a5afe29675d69b605ce906d34fd89c024ac These constitute the bulk of the remaining global mutable state in libcrypto. This commit moves most of them into data.rel.ro, leaving out ERR_str_{functs,libraries,reasons} (which require a slightly different approach) and SYS_str_reasons which is populated on startup. The main observation is that if ERR_load_strings() is called with a 0 lib argument, the ERR_STRING_DATA argument is not actually modified. We could use this fact to cast away const on the caller side and be done with it. We can make this cleaner by adding a helper ERR_load_const_strings() which explicitly avoids the assignment to str->error overriding the error code already set in the table. In order for this to work, we need to sprinkle some const in err/err.c. CMS called ERR_load_strings() with non-0 lib argument, but this didn't actually modify the error data since it ored in the value already stored in the table. Annoyingly, we need to cast const away once, namely in the call to lh_insert() in int_err_set_item(). Fixing this would require changing the public API and is going to be tricky since it requires that the LHASH_DOALL_FN_* types adjust. ok jsing 2024-03-29T02:22:18+00:00 jsing 2024-03-29T02:22:18+00:00 urn:sha1:d4b7d2c84449fd144c1078f6ab2f9ca24691cdeb Somewhere in the past 25 years, the circular dependency between err and pem went away. Stop pulling in pem2.h and just use pem.h directly (pem2.h can probably be removed at some point, but that remains for another day). ok joshua@ tb@ 2024-03-24T06:05:41+00:00 tb 2024-03-24T06:05:41+00:00 urn:sha1:5bb911ebdb5199150af9adab46b9bb77cbfdc087 ok beck 2024-03-02T13:39:28+00:00 tb 2024-03-02T13:39:28+00:00 urn:sha1:b67dd091b5f82f671c4de5665606d30a7de36db5 2024-03-02T11:37:13+00:00 tb 2024-03-02T11:37:13+00:00 urn:sha1:17579c0eb7910d89f824a0cb4f9967d3af8a04ac With ERR_STATE out of the way, we can make CRYPTO_THREADID opaque. The type is still accessed by used public API, but some of the public API can also go away. ok jsing 2024-03-02T10:32:26+00:00 tb 2024-03-02T10:32:26+00:00 urn:sha1:ec2a181702a200c7cbfaa3e93de38f22d7b9cf4b This aligns the prototypes with OpenSSL 1.1. ok jsing 2024-03-02T10:30:48+00:00 tb 2024-03-02T10:30:48+00:00 urn:sha1:d23ca349fd2e45b2231f05fba70d31bc44134e14 The ERR_STATE struct is an unused implementation detail of the horrific error stack code. It is the last public consumer of CRYPTO_THREAD internals. Make this and its accessor internal so we can make the CRYPTO_THREAD struct opaque. ok jsing 2024-02-24T07:53:01+00:00 tb 2024-02-24T07:53:01+00:00 urn:sha1:1ed07476f564ab38570ad487d745791079044274 These don't do anything but return 0 and will be garbage collected in the upcoming bump. ok jsing