openbsd/src/lib/libcrypto/evp/digest.c, branch OPENBSD_6_8_BASEA mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE2019-04-19T17:04:45+00:00Allocate md_data with calloc to avoid use of uninitialised memory.2019-04-19T17:04:45+00:00jsing2019-04-19T17:04:45+00:00urn:sha1:ad2f78627bd2e79d4aba75e47b15534a130af405
Found by Guido Vranken when fuzzing and trying to use GOST with HMAC.
Fix confirmed by Guido; ok tb@
make ENGINE_finish() succeed on NULL and simplify callers as in2018-04-14T07:09:21+00:00tb2018-04-14T07:09:21+00:00urn:sha1:0c5418014797b1fadca3f270eb2f140fd6f5bdf8
OpenSSL commit 7c96dbcdab9 by Rich Salz.
This cleans up the caller side quite a bit and reduces the number of
lines enclosed in #ifndef OPENSSL_NO_ENGINE. codesearch.debian.net
shows that almost nothing checks the return value of ENGINE_finish().
While there, replace a few nearby 'if (!ptr)' with 'if (ptr == NULL)'.
ok jsing, tested by & ok inoguchi
Provide EVP_MD_CTX_new(), EVP_MD_CTX_free() and EVP_MD_CTX_reset().2018-02-17T14:55:31+00:00jsing2018-02-17T14:55:31+00:00urn:sha1:ec57aafcd24236634f3d5828c59235b7eb6d9defuse freezero() instead of memset/explicit_bzero + free. Substantially2017-05-02T03:59:45+00:00deraadt2017-05-02T03:59:45+00:00urn:sha1:5904cc0e04409fde39a97e6580535da34eeb4291
reduces conditional logic (-218, +82).
MOD_EXP_CTIME_MIN_CACHE_LINE_WIDTH cache alignment calculation bn/bn_exp.c
wasn'tt quite right. Two other tricky bits with ASN1_STRING_FLAG_NDEF and
BN_FLG_STATIC_DATA where the condition cannot be collapsed completely.
Passes regress. ok beck
Send the function codes from the error functions to the bit bucket,2017-01-29T17:49:23+00:00beck2017-01-29T17:49:23+00:00urn:sha1:d1f47bd292f36094480caa49ada36b99a69c59b0
as was done earlier in libssl. Thanks inoguchi@ for noticing
libssl had more reacharounds into this.
ok jsing@ inoguchi@
Enable building with -DOPENSSL_NO_DEPRECATED.2015-02-11T03:19:37+00:00doug2015-02-11T03:19:37+00:00urn:sha1:e816a1ec1d4411707051912b945e8eab7a5a94e8
If you didn't enable deprecated code, there were missing err.h and
bn.h includes. This commit allows building with or without deprecated
code.
This was not derived from an OpenSSL commit. However, they recently
enabled OPENSSL_NO_DEPRECATED in git and fixed these header problems
in a different way.
Verified with clang that this only changes line numbers in the generated
asm.
ok miod@
Replace assert() and OPENSSL_assert() calls with proper error return paths.2015-02-10T09:52:35+00:00miod2015-02-10T09:52:35+00:00urn:sha1:edf340ccfb8b64c1c344e29963a2093fe1298a86
Careful review, feedback & ok doug@ jsing@
Introduce EVP_MD_CTX_ctrl(), to allow for fine control of a given digest.2014-11-09T19:12:18+00:00miod2014-11-09T19:12:18+00:00urn:sha1:d92e6fdf5aae7a320effa3de769ce4c0378485c4
This functionality was already available (and optional), and used in the
bowels of the ASN.1 code. This exposes it as a public interface, which will
be used by the upcoming GOST code.
Crank libcrypto minor version.
From Dmitry Eremin-Solenikov.
EVP_DigestInit_ex() may be used to recycle an existing EVP_MD_CTX without having2014-07-13T11:14:02+00:00miod2014-07-13T11:14:02+00:00urn:sha1:e2b8ee83358d7bd430f411de285b5a5c04dd5c30
to reinitialize all of it, especially if it is used with the same MD algorithm.
However, when the MD algorithm changes, it needs to perform more cleanups.
Make that code more closer to what EVP_MD_CTX_cleanup() does by:
- only freeing md_data if EVP_MD_CTX_FLAG_REUSE is not set
- performing an explicit_bzero of md_data before freeing it
- making sure we call EVP_PKEY_CTX_free on the pctx if the allocation for the
new md_data fails.
ok tedu@
if (x) FOO_free(x) -> FOO_free(x).2014-07-12T16:03:37+00:00miod2014-07-12T16:03:37+00:00urn:sha1:068bf464df6ef084067943863d776f59762bfaf0
Improves readability, keeps the code smaller so that it is warmer in your
cache.
review & ok deraadt@