openbsd/src/lib/libcrypto/evp/e_idea.c, branch OPENBSD_7_9_BASE

Make EVP_CIPHER_[gs]et_asn1_iv() local to evp_cipher

2025-05-27T03:58:12+00:00

These formerly public functions have only ever been called from EVP_CIPHER_asn1_to_param() and EVP_CPIHER_param_to_asn1(), either directly if the EVP_CIPH_FLAG_DEFAULT_ASN1 flag is set, or indirectly when set as the .[gs]et_asn1_parameters() method of the EVP_CIPHER. This commit removes their use in .[gs]et_asn1_parameters() dating back to long before the EVP_CIPH_FLAG_DEFAULT_ASN1 was introduced in 2010. This way the only remaining consumer of .[gs]et_asn1_parameters() is RC2. ok jsing

Hide public symbols in evp.h

2024-04-09T13:52:42+00:00

largely mechanically done by the guentherizer 9000 ok tb@

Remove unused app_data from EVP_CIPHER

2024-01-04T17:38:36+00:00

The EVP_CIPHER structs are static const data that the library returns when you call EVP_aes_128_cbc(), for example. It makes no sense whatsoever to hang user data off such a struct, but it's been there since forever. ok jsing

Unbreak the namespace build after a broken mk.conf and tool misfire had

2023-07-07T19:37:54+00:00

me aliasing symbols not in the headers I was procesing. This unbreaks the namespace build so it will pass again ok tb@

Hide symbols in hkdf, evp, err, ecdsa, and ec

2023-07-07T13:54:46+00:00

(part 2 of commit) ok jsing@

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Use LONG_MAX as the limit for ciphers with long based APIs.

2022-09-15T07:04:19+00:00

These ciphers have long based APIs, while EVP has a size_t based API. The intent of these loops is to handle sizes that are bigger than LONG_MAX. Rather than using the rather crazy EVP_MAXCHUNK construct, use LONG_MAX rounded down to a large block size, ensuring that it is a block size multiple. Revert the recently added overflow checks now that this is handled more appropriately. ok tb@

Use correct length for EVP CFB mode ciphers.

2022-09-10T17:39:47+00:00

The BLOCK_CIPHER_* macros contained a bug where the total length is passed to the underlying cipher implementation, rather than the length of the current chunk. Correct this and use the chunk length instead. Should address the remaining issues reported by Coverity. ok tb@

Add bounds checks for various EVP cipher implementations.

2022-09-04T15:45:25+00:00

The EVP cipher API uses size_t, however a number of the underlying implementations use long in their API. This means that an input with size > LONG_MAX will go negative. Found by Coverity, hiding under a large pile of macros. ok tb@

Remove dead code.

2022-09-04T13:55:39+00:00

Only change to generated assembly is due to line numbers.