openbsd/src/lib/libcrypto/evp/encode.c, branch libressl-v2.2.7A mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=libressl-v2.2.72015-08-02T21:54:23+00:00This commit was manufactured by cvs2git to create branch 'OPENBSD_5_8'.2015-08-02T21:54:23+00:00cvs2svnadmin@example.com2015-08-02T21:54:23+00:00urn:sha1:67fcb4ef3942fb3a0f1e18f8ebbe7464120d485aDelete a lot of #if 0 code in libressl.2015-02-07T13:19:15+00:00doug2015-02-07T13:19:15+00:00urn:sha1:a58e958ffece1b48f50bc090357dee2cd5b1bc20
There are a few instances where #if 1 is removed but the code remains.
Based on the following OpenSSL commits. Some of the commits weren't
strictly deletions so they are going to be split up into separate commits.
6f91b017bbb7140f816721141ac156d1b828a6b3
3d47c1d331fdc7574d2275cda1a630ccdb624b08
dfb56425b68314b2b57e17c82c1df42e7a015132
c8fa2356a00cbaada8963f739e5570298311a060
f16a64d11f55c01f56baa62ebf1dec7f8fe718cb
9ccc00ef6ea65567622e40c49aca43f2c6d79cdb
02a938c953b3e1ced71d9a832de1618f907eb96d
75d0ebef2aef7a2c77b27575b8da898e22f3ccd5
d6fbb194095312f4722c81c9362dbd0de66cb656
6f1a93ad111c7dfe36a09a976c4c009079b19ea1
1a5adcfb5edfe23908b350f8757df405b0f5f71f
8de24b792743d11e1d5a0dcd336a49368750c577
a2b18e657ea1a932d125154f4e13ab2258796d90
8e964419603d2478dfb391c66e7ccb2dcc9776b4
32dfde107636ac9bc62a5b3233fe2a54dbc27008
input + ok jsing@, miod@, tedu@
Allow B64_EOF to follow a base64 padding character. This restores previous2014-08-06T16:01:44+00:00jsing2014-08-06T16:01:44+00:00urn:sha1:a246d7144cfefde1781f8320aaa6f081f3cb760b
behaviour that allows a PEM block to be fed through the base64 decoder.
Reported by Dmitry Eremin-Solenikov on tech@
ok deraadt@ tedu@
Only import cryptlib.h in the four source files that actually need it.2014-07-11T08:44:49+00:00jsing2014-07-11T08:44:49+00:00urn:sha1:74e2c009c83ad374bd6acdcfc376a384e25ab007
Remove the openssl public includes from cryptlib.h and add a small number
of includes into the source files that actually need them. While here,
also sort/group/tidy the includes.
ok beck@ miod@
Stop including standard headers via cryptlib.h - pull in the headers that2014-07-10T13:58:23+00:00jsing2014-07-10T13:58:23+00:00urn:sha1:c917c683bc93c68fbf4310ac181f7906e76b3c94
are needed in the source files that actually require them.
ok beck@ miod@
tags as requested by miod and tedu2014-06-12T15:49:31+00:00deraadt2014-06-12T15:49:31+00:00urn:sha1:59f4f2c61d71e266d37dd2fc97615b3fd35b4721More KNF.2014-05-15T15:55:55+00:00jsing2014-05-15T15:55:55+00:00urn:sha1:f6b6054589b1f9aa85fabfe254a9647519d258f2Add checks for invalid base64 encoded data, specifically relating to the2014-05-03T16:54:48+00:00jsing2014-05-03T16:54:48+00:00urn:sha1:899d62e6b1905d0ba40e6f2798a8ad1c1e6f9094
handling of padding. This fixes a crash that can be triggered by feeding
base64 data followed by 64 or more padding characters, which results in a
negative output length.
This issue was reported by David Ramos, although the same bug has been
sitting in the OpenSSL RT since 2011:
https://rt.openssl.org/Ticket/Display.html?id=2608
Worse still, BIO_read seems to be completely unable to detect that the
base64 input was invalid/corrupt - in particular, enabling
BIO_FLAGS_BASE64_NO_NL results in a stream of zero value bytes rather than
no input (possibly a good replacement for /dev/null...), which could
result in nasty consequences. Prior to this fix some zero value bytes were
also injected without this flag being enabled.
The recently added base64 regress triggers and documents these issues
(and also ensures that this change retains functional behaviour).
It is definitly not the correct spelling.2014-05-03T16:30:53+00:00jsing2014-05-03T16:30:53+00:00urn:sha1:ee76a2f3016cd836f22def4fc04f35d15f0e66feKNF.2014-05-03T15:50:24+00:00jsing2014-05-03T15:50:24+00:00urn:sha1:05999277fef08a522a4e057be30fadadba08e1db