openbsd/src/lib/libcrypto/evp/evp_cipher.c, branch OPENBSD_7_9A mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_7_92025-07-02T06:19:46+00:00EVP_CipherInit_ex(): normalize EVP_CIPHER_CTX_ctrl() error check2025-07-02T06:19:46+00:00tb2025-07-02T06:19:46+00:00urn:sha1:ad601ff02961740f5ae318c6636c0f79f9d72ae4
While EVP_CIPHER_CTX_ctrl() can return a negative value this can't
actually happen currently as all ciphers with EVP_CIPH_CTRL_INIT set
normalize the EVP_CTRL_INIT return value to boolean in their ctrl()
methods. Still, this check looks weird in grep, so align it.
ok beck kenjiro
Inline EVP_CIPHER_[gs]et_asn1_iv() in their last callers2025-06-02T08:50:51+00:00tb2025-06-02T08:50:51+00:00urn:sha1:660732fe44b595572e8605f5855d894ff2fa2a04
ok kenjiro
Make EVP_CIPHER_[gs]et_asn1_iv() local to evp_cipher2025-05-27T03:58:12+00:00tb2025-05-27T03:58:12+00:00urn:sha1:68a52297dea2d50284c7a8a12b92d8f2c15421f3
These formerly public functions have only ever been called from
EVP_CIPHER_asn1_to_param() and EVP_CPIHER_param_to_asn1(), either
directly if the EVP_CIPH_FLAG_DEFAULT_ASN1 flag is set, or indirectly
when set as the .[gs]et_asn1_parameters() method of the EVP_CIPHER.
This commit removes their use in .[gs]et_asn1_parameters() dating back
to long before the EVP_CIPH_FLAG_DEFAULT_ASN1 was introduced in 2010.
This way the only remaining consumer of .[gs]et_asn1_parameters() is RC2.
ok jsing
GOST has left the building2025-05-26T12:58:42+00:00tb2025-05-26T12:58:42+00:00urn:sha1:d2463d70a3218b82a784e40274a5073b7e3a241b
(comment tweak, no code change)
Use err_local.h rather than err.h in most places2025-05-10T05:54:39+00:00tb2025-05-10T05:54:39+00:00urn:sha1:41e8f99dd1625a9f0c80ce9d4383e95b18e85709
ok jsing
Hide deprecated functions in evp.h2024-04-10T15:00:38+00:00beck2024-04-10T15:00:38+00:00urn:sha1:20ec75270d82cdbe18bc78b00516a72ae16b122e
use LCRYPTO_UNUSED and remove the LIBRESSL_INTERNAL guard around them.
ok tb@
Hide public symbols in evp.h2024-04-09T13:52:42+00:00beck2024-04-09T13:52:42+00:00urn:sha1:9835bb3c82adc630df1f3aaa7dfbf7f0506b0bc4
largely mechanically done by the guentherizer 9000
ok tb@
Fix signature and semantics of EVP_{CIPHER,MD}_CTX_init()2024-03-02T09:55:30+00:00tb2024-03-02T09:55:30+00:00urn:sha1:4083c1a64fc21730cb59ac92344eaeeda5fd688b
When the EVP_CIPHER_CTX and the EVP_MD_CTX were still expected to live
on the stack, these initialization APIs were wrappers around memset.
In OpenSSL 1.1, somebody removed them and carelessly made _init() an
alias of _reset() aka _cleanup(). As a consequence, both signature and
semantics changed.
Unsurprisingly, there is now code out there that actually uses the new
semantics, which causes leaks on LibreSSL and older OpenSSL. This aligns
our _init() with OpenSSL 1.1 semantics.
ok jsing
Remove custom key length handling2024-02-24T08:00:37+00:00tb2024-02-24T08:00:37+00:00urn:sha1:1fc6cbdf068b16378dacfb22c3ce1e29313ee314
No cipher in libcrypto is marked EVP_CIPH_CUSTOM_KEY_LENGTH and no control
handler deals with EVP_CTRL_SET_KEY_LENGTH, which means that this code is
dead as far as libcrypto is concerned. Almost nothing uses EVP_CIPHER_meth*
(this was added for a single project) and nothing sets a custom ctrl. This
isn't going to change anyway since EVP_CIPHER_meth* is deprecated in order
to promote more provider beauty.
ok beck jsing
Align EVP_CIPHER_CTX_init() and _legacy_clear()2024-02-18T15:53:54+00:00tb2024-02-18T15:53:54+00:00urn:sha1:f63cb33bf7e29ee6ba85dbeb12a51f1fba4bab1e