openbsd/src/lib/libcrypto/evp/p_legacy.c, branch OPENBSD_7_9_BASE

EVP_SealInit(): clear random key on exit

2026-01-30T13:57:13+00:00

ok jsing kenjiro

EVP_{Open,Seal}Init(): remove redundant EVP_CIPHER_CTX_reset() calls

2026-01-30T13:54:28+00:00

The subsequent EVP_{Decrypt,Encrypt}Init_ex() calls already do that. pointed out by jsing

EVP_SealInit(): minor cleanup.

2026-01-30T13:51:44+00:00

Explicitly compare pointers against NULL, turn the function into single exit, add hint at why npubk <= 0 or pubk == NULL are a success path: The documentation briefly explains that EVP_OpenInit() and EVP_SealInit() is able to initialize the EVP_CIPHER_CTX in two steps exactly like the EVP_CipherInit_ex() API they wrap: the first call with non-NULL cipher (aka type) only sets the cipher on the ctx, then it returns to allow callers to customize the EVP_CIPHER_CTX, and a second call with cipher == NULL skips the initialization and finishes the ctx setup by setting key and iv. Prompted by a report by Niels Dossche. ok jsing kenjiro

EVP_SealInit: do not return -1 on error

2026-01-30T13:47:22+00:00

It is documented that EVP_SealInit() returns 0 on error. So -1 is wrong. Reported by Niels Dossche ok jsing kenjiro

EVP_OpenInit(): minor cleanup

2026-01-30T13:42:46+00:00

Explicitly compare pointers against NULL, turn the function into single exit and explain why priv == NULL is a success (hint: muppet API). Prompted by a report by Niels Dossche. ok jsing kenjiro

Use err_local.h rather than err.h in most places

2025-05-10T05:54:39+00:00

ok jsing

Hide public symbols in evp.h

2024-04-09T13:52:42+00:00

largely mechanically done by the guentherizer 9000 ok tb@

Check the return value of EVP_CIPHER_CTX_reset()

2024-03-28T01:42:02+00:00

The function call can't actually fail, but all other calls check its return value. ok joshua jsing

Clean up use of EVP_CIPHER_CTX_{legacy_clear,cleanup} in EVP_OpenInit

2024-03-26T05:22:50+00:00

ok tb@

Use EVP_CIPHER_CTX_legacy_clear() internally

2024-02-18T15:44:10+00:00

ok jsing