openbsd/src/lib/libcrypto/evp/p_lib.c, branch OPENBSD_7_9_BASE

Const correct EVP_PKEY_get{0,1}_{DH,DSA,EC_KEY,RSA}()

2025-07-02T06:36:52+00:00

These are safe to call concurrently and they don't modify the memory region pointed to by the pkey - they only bump the refcount of the key hanging off of it. The returned "legacy" key has to be handled with care in threaded constexts, so it is handed back as non-const. This also matches what EVP_PKEY_get0() always had. This way our signature is identical to BoringSSL's and doesn't cause compiler warnings in code that overuses const because one of the many API incoherencies added by OpenSSL 3 was to turn get0 into a function that takes and returns const while leaving get1 as it was. dlg agrees ok kenjiro

Use err_local.h rather than err.h in most places

2025-05-10T05:54:39+00:00

ok jsing

Garbage collect unused attributes member from EVP_PKEY

2024-08-22T12:24:24+00:00

ok miod

Hide public symbols in evp.h

2024-04-09T13:52:42+00:00

largely mechanically done by the guentherizer 9000 ok tb@

Unhook and remove GOST and STREEBOG

2024-03-02T11:17:27+00:00

This stops compiling the GOST source. The current implementation is low quality and got in the way, especially in libssl. While we would be open for GOST support, it needs to be significantly better than what we have had and it also needs a maintainer. Add OPENSSL_NO_GOST to opensslfeatures and stop installing gost.h. Some code wrapped in #ifndef OPENSSL_NO_GOST will be removed later. ok jsing

EVP_PKEY_asn1_find_str() tweaks

2024-01-05T21:22:01+00:00

Switch i to a size_t and improve a flag check. Part of an earlier diff that was ok jsing but were lost when I reworked the diff.

Clean up EVP_PKEY_asn1_get0_info() a bit

2024-01-04T17:22:29+00:00

Use better variable names without silly p prefix and use explicit checks against NULL.

Clean up EVP_PKEY_asn1_find_str()

2024-01-04T17:17:40+00:00

Use slightly better argument and variable names, do not pointlessly try to match a string of negative length < -1, use a size_t for the strlen() and preserve the logic that allows lookup by a string fragment rather than a full string. ok jsing

Simplify EVP_PKEY_asn1_find()

2024-01-04T17:08:57+00:00

EVP_PKEY_asn1_find() finds the EVP_PKEY_ASN1_METHOD underlying the method or alias with nid (or, rather, pkey_id) passed in. Now that we have the base method stored in a pointer, we can return that method after a simple lookup of said nid (or, rather, pkey_id). ok jsing

Replace .pkey_base_id with a .base_method pointer

2024-01-04T17:01:26+00:00

Every EVP_PKEY_ASN1_METHOD is either an ASN.1 method or an alias. As such it resolves to an underlying ASN.1 method (in one step). This information can be stored in a base_method pointer in allusion to the pkey_base_id, which is the name for the nid (aka pkey_id aka type) of the underlying method. For an ASN.1 method, the base method is itself, so the base method is set as a pointer to itself. For an alias it is of course a pointer to the underlying method. Then obviously ameth->pkey_base_id is the same as ameth->base_method->pkey_id, so rework all ASN.1 methods to follow that. ok jsing