openbsd/src/lib/libcrypto/evp, branch OPENBSD_7_9

EVP_SealInit(): clear random key on exit

2026-01-30T13:57:13+00:00

ok jsing kenjiro

EVP_{Open,Seal}Init(): remove redundant EVP_CIPHER_CTX_reset() calls

2026-01-30T13:54:28+00:00

The subsequent EVP_{Decrypt,Encrypt}Init_ex() calls already do that. pointed out by jsing

EVP_SealInit(): minor cleanup.

2026-01-30T13:51:44+00:00

Explicitly compare pointers against NULL, turn the function into single exit, add hint at why npubk <= 0 or pubk == NULL are a success path: The documentation briefly explains that EVP_OpenInit() and EVP_SealInit() is able to initialize the EVP_CIPHER_CTX in two steps exactly like the EVP_CipherInit_ex() API they wrap: the first call with non-NULL cipher (aka type) only sets the cipher on the ctx, then it returns to allow callers to customize the EVP_CIPHER_CTX, and a second call with cipher == NULL skips the initialization and finishes the ctx setup by setting key and iv. Prompted by a report by Niels Dossche. ok jsing kenjiro

EVP_SealInit: do not return -1 on error

2026-01-30T13:47:22+00:00

It is documented that EVP_SealInit() returns 0 on error. So -1 is wrong. Reported by Niels Dossche ok jsing kenjiro

EVP_OpenInit(): minor cleanup

2026-01-30T13:42:46+00:00

Explicitly compare pointers against NULL, turn the function into single exit and explain why priv == NULL is a success (hint: muppet API). Prompted by a report by Niels Dossche. ok jsing kenjiro

Remove unused function pointer from struct aead_aes_gcm_ctx.

2025-07-22T09:31:09+00:00

Remove remaining block128_f casts from EVP AES.

2025-07-22T09:29:31+00:00

Use aes_encrypt_block128() instead of AES_encrypt(), avoiding risky casts.

Move AES-NI for ECB out of EVP.

2025-07-22T09:13:49+00:00

Make aes_ecb_encrypt_internal() replaceable and provide machine dependent versions for amd64 and i386, which dispatch to AES-NI if appropriate. Remove the AES-NI specific EVP methods for ECB. This removes the last of the machine dependent code from EVP AES. ok bcook@ joshua@ tb@

Move AES-NI from EVP to AES for CCM mode.

2025-07-21T10:24:23+00:00

The mode implementation for CCM has two variants - one takes the block function, while the other takes a "ccm64" function. The latter is expected to handle the lower 64 bits of the IV/counter but only for 16 byte blocks. The AES-NI implementation for CCM currently uses the second variant. Provide aes_ccm64_encrypt_internal() as a function that can be replaced on a machine dependent basis, along with an aes_ccm64_encrypt_generic() function that provides the default implementation and can be used as a fallback. Wire up the AES-NI version for amd64 and i386, change EVP's aes_ccm_cipher() to use CRYPTO_ctr128_{en,de}crypt_ccm64() with aes_ccm64_encrypt_internal()) and remove the various AES-NI specific EVP_CIPHER methods for CCM. ok tb@

Simplify AES-XTS implementation and remove AES-NI specific code from EVP.

2025-07-13T06:01:33+00:00

Provide aes_xts_encrypt_internal() and call that from aes_xts_cipher(). Have amd64 and i386 provide their own versions that dispatch to aesni_xts_encrypt()/aesni_xts_decrypt() as appropriate. The AESNI_CAPABLE code and methods can then be removed. ok tb@