openbsd/src/lib/libcrypto/gost, branch OPENBSD_7_3_BASE

Call BN_free() instead of BN_clear_free().

2023-03-07T09:27:10+00:00

BN_clear_free() is a wrapper that calls BN_free() - call BN_free() directly instead. ok tb@

gost: add missing BN_CTX_{start,end}() pair

2023-01-15T13:58:44+00:00

The new BN_CTX code enforces that the context be started before a BIGNUM can be obtained from it via BN_CTX_get(), tests for ssl/interop and the openssl app broke, implying missing test coverage in libcrypto itself. Add the obviously missing bits. reported by anton ok jsing

BN_one() can fail, check its return value.

2022-12-01T02:58:31+00:00

ok tb@

Make header guards of internal headers consistent

2022-11-26T17:23:18+00:00

Not all of them, only those that didn't leak into a public header... Yes.

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Remove mkerr.pl remnants from LibreSSL

2022-07-12T14:42:50+00:00

This script is not used at all and files are edited by hand instead. Thus remove misleading comments incl. the obsolete script/config. Feedback OK jsing tb

Avoid segfaults in EVP_PKEY_CTX_free()

2022-03-30T07:17:48+00:00

It is possible to call pmeth->cleanup() with an EVP_PKEY_CTX whose data is NULL. If pmeth->init() in int_ctx_new() fails, EVP_PKEY_CTX_free() is called with such a context. This in turn calls pmeth->cleanup(), and thus these cleanup functions must be careful not to use NULL data. Most of them are, but one of GOST's functions and HMAC's aren't. Reported for HMAC by Masaru Masada https://github.com/libressl-portable/openbsd/issues/129 ok bcook jsing

gost needs to look into ecs_locl.h

2022-01-07T09:40:03+00:00

Check BIO_indent() return like all the others in this file.

2021-12-26T15:38:49+00:00

CID 345118

Include evp_locl.h where it will be needed once most structs from

2021-12-12T21:30:14+00:00

evp.h will be moved to evp_locl.h in an upcoming bump. ok inoguchi