openbsd/src/lib/libcrypto/gost, branch libressl-v2.1.2 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v2.1.2 2014-12-07T16:33:51+00:00 Make GOST compile with a strict C compiler - in this case incrementing a 2014-12-07T16:33:51+00:00 jsing 2014-12-07T16:33:51+00:00 urn:sha1:ee67fae33e31b0a137774a402a100e614c3cbc9d void pointer is undefined and initialising an array with {} is a syntax error. Based on a diff from kinichiro inoguchi. Correctly output the result in STREEBOG512_Final() when running on a big-endian 2014-12-07T16:07:56+00:00 miod 2014-12-07T16:07:56+00:00 urn:sha1:9dcd1d10adfff562d2544201168edd392ce8c05a system. *blush* Argh, another bug introduced in r1.3; Dmitry Eremin-Solenikov 2014-11-18T21:18:56+00:00 miod 2014-11-18T21:18:56+00:00 urn:sha1:b1885bf790faeaebdb0a37ac7472380579cc7508 Return success in param_copy_gost01() if there is no private key to copy; 2014-11-18T05:27:05+00:00 miod 2014-11-18T05:27:05+00:00 urn:sha1:1999f4a4d9352e1879578bcd782cfdfa56f74f46 broken in r1.3. Spotted by Dmitry Eremin-Solenikov Add many missing error checks (probably not exhaustive, but a good start): 2014-11-13T20:29:55+00:00 miod 2014-11-13T20:29:55+00:00 urn:sha1:914b996e03c70669eceeed1ebc536033930db17b - make VKO_compute_key() no longer void so that it can return failure. - fix unchecked allocations in too many routines to mention /-: - fix unchecked BN operations in gost2001_do_sign(), gost2001_do_verify(), VKO_compute_key(). - fix the gost2001_do_sign() interface violation by having its sole caller free the BIGNUM it passes to that function by itself, instead of having the callee do this. Reviewed (except for the last item) by Dmitry Eremin-Solenikov. KNF (when not conflicting with other cleanup changes in progress) 2014-11-09T23:06:52+00:00 miod 2014-11-09T23:06:52+00:00 urn:sha1:b6d8b8dcb0f5eb1f67698fd5bcb64941d16bfd9a Remove DEBUG_SIGN code. Make sure gost_key_unwrap_crypto_pro() returns failure 2014-11-09T19:28:44+00:00 miod 2014-11-09T19:28:44+00:00 urn:sha1:57ca3ba27d218460a1eb477e8cd28436c1e2e124 instead of a printf and a success return, when the operation fails. Rename internal yet public key_{un,}wrap_crypto_pro symbols by prepending a 2014-11-09T19:27:29+00:00 miod 2014-11-09T19:27:29+00:00 urn:sha1:8d7e3ea8f1216dc935870471c3e92e8eeb9a9450 `gost_' prefix to them, so that we do not pollute the global namespace too much. Replace RAND_bytes() usage with arc4random_buf(). 2014-11-09T19:24:30+00:00 miod 2014-11-09T19:24:30+00:00 urn:sha1:f2444d1b3e58b48bfb8f82ce985ac63b36d82059 GOST crypto algorithms (well, most of them), ported from the removed GOST 2014-11-09T19:17:13+00:00 miod 2014-11-09T19:17:13+00:00 urn:sha1:35d7dd4666beda50f5094b8804802132fbe722ef engine to regular EVP citizens, contributed by Dmitry Eremin-Solenikov; libcrypto bits only for now. This is a verbatim import of Dmitry's work, and does not compile in this state; the forthcoming commits will address these issues. None of the GOST code is enabled in libcrypto yet, for it still gets compiled with OPENSSL_NO_GOST defined. However, the public header gost.h will be installed.