openbsd/src/lib/libcrypto/gost, branch master

Unhook and remove GOST and STREEBOG

2024-03-02T11:17:27+00:00

This stops compiling the GOST source. The current implementation is low quality and got in the way, especially in libssl. While we would be open for GOST support, it needs to be significantly better than what we have had and it also needs a maintainer. Add OPENSSL_NO_GOST to opensslfeatures and stop installing gost.h. Some code wrapped in #ifndef OPENSSL_NO_GOST will be removed later. ok jsing

Replace .pkey_base_id with a .base_method pointer

2024-01-04T17:01:26+00:00

Every EVP_PKEY_ASN1_METHOD is either an ASN.1 method or an alias. As such it resolves to an underlying ASN.1 method (in one step). This information can be stored in a base_method pointer in allusion to the pkey_base_id, which is the name for the nid (aka pkey_id aka type) of the underlying method. For an ASN.1 method, the base method is itself, so the base method is set as a pointer to itself. For an alias it is of course a pointer to the underlying method. Then obviously ameth->pkey_base_id is the same as ameth->base_method->pkey_id, so rework all ASN.1 methods to follow that. ok jsing

Split ameth arrays into individual methods

2024-01-04T16:41:56+00:00

For some reason DSA, GOST, and RSA had their ASN.1 methods stored in an array. This is clumsy and the only benefit is that one saves a few externs in p_lib.c. They were also arranged by ascending NID because of bsearch() madness. Split them up and arrange the methods by name, which is much saner and simpler. ok jsing

Replace EVP_KEY_assign_GOST() calls with EVP_PKEY_set_type()

2023-12-28T21:53:09+00:00

Calling EVP_KEY_assign_GOST(pkey, NULL) has the same effect as calling EVP_PKEY_set_type(pkey, EVP_PKEY_GOSTR01). The only difference is that the latter form allows for error checking while the former won't let you do that. Add comments explaining what we're actually doing: freeing and zeroing the pkey->pkey union. ok jsing

Fix another EVP_PKEY_assign_GOST() call

2023-12-28T21:49:07+00:00

Again this can't actually fail, but if it did, things would leak. Call GOST_KEY_free() in the error path. ok jsing CID 471706 (false positive)

Clean up pkey_gost_mac_keygen()

2023-12-28T21:47:17+00:00

Make this function single exit, check and assign and finally error check EVP_PKEY_assign(). This can't actually fail currently, but if it did, things would leak. Free the key data with freezero. ok jsing CID 471704 (false positive)

Stop including ecdsa.h and ecdh.h internally

2023-07-28T15:50:33+00:00

These headers are now reduced to #include and are provided for compatiblity only. There's no point in using them. At the same time garbage collect the last uses of OPENSSL_NO_{ECDSA,ECDH} in our tree. ok jsing

Fix two EC_POINT_is_on_curve() checks

2023-07-24T17:08:53+00:00

This API can fail for various reasons, in which case it returns -1, so you need to check if (EC_POINT_is_on_curve_checks(...) <= 0). ok miod

Hide symbols in gost.

2023-07-08T14:30:44+00:00

ok tb@ after some puking in his mouth.

Rename ecs_local.h into ecdsa_local.h

2023-07-05T11:37:46+00:00