openbsd/src/lib/libcrypto/hmac/hm_pmeth.c, branch OPENBSD_7_9_BASE

Rework and fix pkey_hmac_keygen()

2023-12-28T22:00:56+00:00

The usual: single exit, error check all functions even if they can't actually fail. This one was flagged again. ok jsing CID 471706 (false positive)

Ignore ENGINE at the API boundary

2023-11-29T21:35:57+00:00

This removes the remaining ENGINE members from various internal structs and functions. Any ENGINE passed into a public API is now completely ignored functions returning an ENGINE always return NULL. ok jsing

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Change the pkey.ptr from char * to void *

2022-11-18T14:45:10+00:00

Now that EVP_PKEY is opaque, there is no reason to keep the ptr member of the pkey union as a weird char pointer, a void pointer will do. This avoids a few stupid casts and simplifies an upcoming diff. ok jsing

Avoid segfaults in EVP_PKEY_CTX_free()

2022-03-30T07:17:48+00:00

It is possible to call pmeth->cleanup() with an EVP_PKEY_CTX whose data is NULL. If pmeth->init() in int_ctx_new() fails, EVP_PKEY_CTX_free() is called with such a context. This in turn calls pmeth->cleanup(), and thus these cleanup functions must be careful not to use NULL data. Most of them are, but one of GOST's functions and HMAC's aren't. Reported for HMAC by Masaru Masada https://github.com/libressl-portable/openbsd/issues/129 ok bcook jsing

pkey_hmac_init(): use calloc()

2022-03-30T07:12:30+00:00

Instead of using malloc() and setting most struct members to 0, simply use calloc(). ok bcook jsing

Add a mostly empty hmac_local.h. HMAC_CTX and a few other things

2021-12-12T21:27:38+00:00

from hmac.h will be moved there in an umpcoming bump. Include this file where it will be needed. ok inoguchi

use freezero() instead of memset/explicit_bzero + free. Substantially

2017-05-02T03:59:45+00:00

reduces conditional logic (-218, +82). MOD_EXP_CTIME_MIN_CACHE_LINE_WIDTH cache alignment calculation bn/bn_exp.c wasn'tt quite right. Two other tricky bits with ASN1_STRING_FLAG_NDEF and BN_FLG_STATIC_DATA where the condition cannot be collapsed completely. Passes regress. ok beck

Correct spelling of OPENSSL_cleanse.

2015-09-10T15:56:26+00:00

ok miod@

Only import cryptlib.h in the four source files that actually need it.

2014-07-11T08:44:49+00:00

Remove the openssl public includes from cryptlib.h and add a small number of includes into the source files that actually need them. While here, also sort/group/tidy the includes. ok beck@ miod@