openbsd/src/lib/libcrypto/hmac, branch libressl-v3.9.2

Use EVP_MD_CTX_legacy_clear() internally

2024-02-18T15:45:42+00:00

ok jsing

Replace .pkey_base_id with a .base_method pointer

2024-01-04T17:01:26+00:00

Every EVP_PKEY_ASN1_METHOD is either an ASN.1 method or an alias. As such it resolves to an underlying ASN.1 method (in one step). This information can be stored in a base_method pointer in allusion to the pkey_base_id, which is the name for the nid (aka pkey_id aka type) of the underlying method. For an ASN.1 method, the base method is itself, so the base method is set as a pointer to itself. For an alias it is of course a pointer to the underlying method. Then obviously ameth->pkey_base_id is the same as ameth->base_method->pkey_id, so rework all ASN.1 methods to follow that. ok jsing

Rework and fix pkey_hmac_keygen()

2023-12-28T22:00:56+00:00

The usual: single exit, error check all functions even if they can't actually fail. This one was flagged again. ok jsing CID 471706 (false positive)

Ignore ENGINE at the API boundary

2023-11-29T21:35:57+00:00

This removes the remaining ENGINE members from various internal structs and functions. Any ENGINE passed into a public API is now completely ignored functions returning an ENGINE always return NULL. ok jsing

Wire up truncated SHA-2, SHA-3 and related things

2023-04-25T15:48:48+00:00

from jsing

libressl _namespace.h: adjust _ALIAS() to require a semicolon

2023-02-16T08:38:17+00:00

LCRYPTO_ALIAS() and LSSL_ALIAS() contained a trailing semicolon. This does not conform to style(9), breaks editors and ctags and (most importantly) my workflow. Fix this by neutering them with asm("") so that -Wpedantic doesn't complain. There's precedent in libc's namespace.h fix suggested by & ok jsing

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Unindent and check some pointers explicitly against NULL

2022-11-19T04:36:52+00:00

Remove HMAC PRIVATE KEY support

2022-11-19T04:32:49+00:00

This is an undocumented feature of openssl genpkey for testing purposes. Emilia removed support for this 'bogus private key format' from OpenSSL in 2017 in commit c26f655fdd18ac19016c1c0496105f5256a1e84d. ok jsing

Check os for NULL before dereferencing it

2022-11-18T20:03:36+00:00

Avoids a segfault when both priv == NULL and os == NULL. ok miod