openbsd/src/lib/libcrypto/kdf/hkdf_evp.c, branch OPENBSD_7_9_BASE

Add NULL checks to HKDF and TLS1-PRF EVP_PKEY cleanup functions

2025-05-21T03:53:20+00:00

Check if ctx->data is NULL before calling freezero(). Also add HKDF and TLS1-PRF to the EVP_PKEY cleanup regression test, as they no longer crash with this change. ok tb@

Use err_local.h rather than err.h in most places

2025-05-10T05:54:39+00:00

ok jsing

Adjust EVP_PKEY_CTRL_HKDF_KEY to OpenSSL's semantics

2023-06-26T08:57:17+00:00

For some reason there is no NULL check on setting the HKDF key for p2 like in the other cases in the switch, instead OpenSSL fail in memdup, nulling out the key but leaving he key_len at the old value. This looks accidental but our behavior makes some haproxy regress tests segfault. So mimic weird OpenSSL semantics but in addition set the key_len to 0. Reported by Ilya Shipitsin ok jsing

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Simplify: freezero() is NULL safe; assign + test in one go, as usual.

2022-05-05T19:48:06+00:00

ok jsing

Avoid malloc(0) in EVP_PKEY_CTX_set1_hkdf_key()

2022-05-05T19:46:36+00:00

ok jsing

Securely wipe the entire HKDF_PKEY_CTX instead of only taking care of

2022-05-05T19:44:23+00:00

a piece of the embedded info array. ok jsing

Fix argument order in HKDF and HKDF_extract().

2022-05-05T11:26:36+00:00

Translate from OpenSSL's HKDF API to BoringSSL API.

2022-05-05T08:14:14+00:00

ok beck jsing

Remove function codes from errors, i.e., KDFerr(A, B) -> KDFerror(B)

2022-05-05T08:10:39+00:00

ok beck jsing