openbsd/src/lib/libcrypto/lhash, branch libressl-v2.7.2 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v2.7.2 2016-11-08T20:20:06+00:00 Use more homogeneous types and avoid a possible right shift by 32 in 2016-11-08T20:20:06+00:00 miod 2016-11-08T20:20:06+00:00 urn:sha1:e4634bff5bb1923588c280b2a7eb67b2365ebd69 lh_strhash(). ok guenther@ Only import cryptlib.h in the four source files that actually need it. 2014-07-11T08:44:49+00:00 jsing 2014-07-11T08:44:49+00:00 urn:sha1:74e2c009c83ad374bd6acdcfc376a384e25ab007 Remove the openssl public includes from cryptlib.h and add a small number of includes into the source files that actually need them. While here, also sort/group/tidy the includes. ok beck@ miod@ Explicitly include <openssl/opensslconf.h> in every file that references 2014-07-10T22:45:58+00:00 jsing 2014-07-10T22:45:58+00:00 urn:sha1:62348213609ef233110561d1a6ed67ad66df1c7e an OPENSSL_NO_* define. This avoids relying on something else pulling it in for us, plus it fixes several cases where the #ifndef OPENSSL_NO_XYZ is never going to do anything, since OPENSSL_NO_XYZ will never defined, due to the fact that opensslconf.h has not been included. This also includes some miscellaneous sorting/tidying of headers. remove unused, private version strings except SSL_version_str 2014-07-09T11:10:51+00:00 bcook 2014-07-09T11:10:51+00:00 urn:sha1:0563b5d49da5a96960925938b3e4f3152e6f5c92 Also remove unused des_ver.h, which exports some of these strings, but is not installed. ok miod@ tedu@ tags as requested by miod and tedu 2014-06-12T15:49:31+00:00 deraadt 2014-06-12T15:49:31+00:00 urn:sha1:59f4f2c61d71e266d37dd2fc97615b3fd35b4721 Remove various test stubs. The good ones have been moved by jsing 2014-06-07T15:06:24+00:00 deraadt 2014-06-07T15:06:24+00:00 urn:sha1:9c53764a0ba4c6e9262d0f1609e2b5f26d82e845 and others to the regress framework. These remaining ones just muddle us up when re-reading code repeatedly. ok jsing malloc() result does not need a cast. 2014-06-07T14:41:57+00:00 deraadt 2014-06-07T14:41:57+00:00 urn:sha1:800fbde652d67326eeb163d56d8f72ebb239b3c4 ok miod I do not have time to describe how bad the realloc() uses in here, now 2014-05-29T21:42:44+00:00 deraadt 2014-05-29T21:42:44+00:00 urn:sha1:4089f5fc0965b7893c718c54c03be24eb1edd2a0 being relaced by reallocarray(). you will have to look at the diff. there can be no explanations for the extra casts. as beck says, "Don't go towards the light theo!" ok beck tedu ok, next pass after review: when possible, put the reallocarray arguments 2014-05-29T21:19:30+00:00 deraadt 2014-05-29T21:19:30+00:00 urn:sha1:44c9da02b72b146dbbcafcaec3c3976d04f5c0df in the "size_t nmemb, size_t size" convert 53 malloc(a*b) to reallocarray(NULL, a, b). that is 53 2014-05-29T21:07:43+00:00 deraadt 2014-05-29T21:07:43+00:00 urn:sha1:642d45ae22413aa8195b105d051ca8896e782c5d potential integer overflows easily changed into an allocation return of NULL, with errno nicely set if need be. checks for an allocations returning NULL are commonplace, or if the object is dereferenced (quite normal) will result in a nice fault which can be detected & repaired properly. ok tedu