A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_9 2025-06-08T22:40:31+00:00 2025-06-08T22:40:31+00:00 schwarze 2025-06-08T22:40:31+00:00 urn:sha1:8be86af02fed1bda350c8dd14ee064cb66e3b0f5 2025-03-25T11:54:34+00:00 tb 2025-03-25T11:54:34+00:00 urn:sha1:1246a392e49ed859fbba9a9b3352aee5dca07e54 The current documentation was clearly incorrect since a return of -1 from the methods is explicitly intercepted and translated to 0. schwarze and I both audited the tree and concluded that only 0 and 1 is possible. OpenSSL 3 broke this API contract and now has explicit return -1 in the convoluted 200-line maze this simple function has become with recent provider improvements. So add a small sentence hinting at that. Nobody will be surprised to read that with OpenSSL's characteristic penchant for needless inconsistency the return value checks in their tree are all over the place and sometimes incorrect. ok schwarze (with two tweaks) 2024-12-08T17:41:23+00:00 schwarze 2024-12-08T17:41:23+00:00 urn:sha1:ee3d1c0f143450b3ef7e6244b9b1b99567a19486 and document them properly in their own manual page, including the control commands EVP_CTRL_SET_RC2_KEY_BITS and EVP_CTRL_GET_RC2_KEY_BITS that were so far undocumented. Arguably, the main benefit is another small step making the important, but still obese EVP_EncryptInit(3) manual page more palatable. 2023-10-01T18:23:50+00:00 tb 2023-10-01T18:23:50+00:00 urn:sha1:14325811a46be3e6d6d9a2f3e7431ed8789a08ed We aligned with upstream behavior. Let's document it properly. Surprisingly, OpenSSL 1.1 half-assed the docs: two parts of the manual contradict each other. The part getting EVP_CIPHER_CTX_iv_length() right, incorrectly documents possible -1 return value to EVP_CIPHER_iv_length(). OpenSSL 3 documentation improvement efforts seem to have tried to address this issue with the result that the manual is now entirely wrong when it comes to the EVP_CIPHER_CTX_iv_length() replacement. Par for the course. 2023-08-31T17:27:41+00:00 schwarze 2023-08-31T17:27:41+00:00 urn:sha1:718a51ea125c68db5409e266fe178f9ad937b59c and EVP_CIPHER_CTX_set_flags(3) out of the excessively large and unwieldy EVP_EncryptInit(3). This causes a number of inaccuracies and gaps to stand out, but i'm not mixing text changes or content additions into this split. Using very useful feedback from tb@ regarding what belongs together and how important the various functions are. I refrained from bothering him with the complete patch, but he likes the general direction.