openbsd/src/lib/libcrypto/objects/obj_dat.c, branch OPENBSD_7_9_BASE

Use err_local.h rather than err.h in most places

2025-05-10T05:54:39+00:00

ok jsing

obj_dat: remove parens from return

2025-02-26T10:48:25+00:00

obj_dat: don't shift a->length into the sign bit

2025-02-26T09:52:55+00:00

For an OID of excessive length >= 2^12, a->length << 20L is undefined, so add a cast to the target type of (unsigned long). From Kenjiro Nakayama

obj_dat: don't shift ca->type into the sign bit

2025-02-26T09:49:54+00:00

This is undefined for a ca->type of ADDED_LNAME (2) and ADDED_NID (3) when ca->type << 30L results in a shift into the sign bit, so add a cast to the target type of unsigned long. From Kenjiro Nakayama

Remove lhash_local.h.

2024-07-14T14:32:45+00:00

lhash_local.h was previously needed since conf/conf_api.c and objects/obj_dat.c were fiddling with lhash internals when deleting via a callback. Since we no longer need to do that, inline the structs in lhash.c and remove the header. ok tb@

fix line wrapping in function definition

2024-05-08T16:35:05+00:00

Make LHASH_OF() and STACK_OF() use opaque structs

2024-03-02T11:11:11+00:00

This removes internals of these two special snowflakes and will allow further simplifications. Unfortunately, there are some pieces of software that actually use LHASH_OF() (looking at you, pound, Ruby, and openssl(1)), so we get to keep exposing this garbage, at least for now. Expose lh_error() as a symbol to replace a macro reaching into _LHASH. lh_down_load() is no longer available. _LHASH and _STACK are now opaque, LHASH_NODE becomes internal-only. from jsing

Make OBJ_add_object() static

2024-03-02T09:49:45+00:00

This is another implementation detail that should never have leaked out of the library. Only OBJ_create() ever used this. ok jsing

Remove OBJ_bsearch_()

2024-03-02T09:47:16+00:00

The only reason this has still been part of the public API was that libssl used it for cipher lookup. This was fixed by replacing the lookup by proper bsearch() -- why OpenSSL felt the need to reinvent ANSI C API badly will forever remain a mystery. The stack code in libcrypto still uses a version of this. This should be rewritten. It will be a bit easier once sk_find_ex() is removed. ok jsing

Neuter OBJ_bsearch{_,ex_}()

2024-02-26T15:00:30+00:00

Make these functions always fail. A copy of OBJ_bsearch_ex_() is kept in stack.c, where it is still used by internal_find() for sk_find{,_ex}(). sk_find_ex() will be removed in the upcoming bump, and then we can simplify or rewrite what's still needed. ok jsing