openbsd/src/lib/libcrypto/objects, branch OPENBSD_7_4_BASE A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_4_BASE 2023-09-05T14:59:00+00:00 Improve error handling in OBJ_add_object() 2023-09-05T14:59:00+00:00 tb 2023-09-05T14:59:00+00:00 urn:sha1:26fbf3218b1396b44312a1eaf026d8a5ff25bd80 There is no need for a helper function to obfuscate lh_ADDED_OBJ_new(). Just call the real thing directly. Adding an object with a NID of NID_undef basically amounts to disabling a built-in OID. It does so in an incoherent fashion and the caller can't easily tell success from failure of the operation. Arguably the result is a corrupted objects table. Let's not allow adding such an object in an attempt at keeping things slightly more coherent. Issue noted and initial diff by schwarze while writing documentation ok schwarze Garbage collect two commented abort() 2023-08-17T09:28:43+00:00 tb 2023-08-17T09:28:43+00:00 urn:sha1:d6c19e9056b96c1aa2e38f4643a633b2647fa22c Make the local ASN1_OBJECTs const 2023-08-17T09:27:43+00:00 tb 2023-08-17T09:27:43+00:00 urn:sha1:b297b6a50c9867c398863d25a710550e7a8450e4 ok jsing Remove some unnecessary else branches 2023-08-17T09:26:09+00:00 tb 2023-08-17T09:26:09+00:00 urn:sha1:3935258ee87f65e941a7fcb068549d1bbde29904 Remove some parents from return statements 2023-08-17T09:24:50+00:00 tb 2023-08-17T09:24:50+00:00 urn:sha1:890eabf6ece334e3936a66f5b3ecbbd96e0c0afa Use cmp instead of i for the result of a comparison 2023-08-17T09:22:56+00:00 tb 2023-08-17T09:22:56+00:00 urn:sha1:9d92214a88ee23021bfb3209d3bfd587966de9c6 ok jsing Use OBJ_cmp() instead of inlining two variants 2023-08-17T09:18:21+00:00 tb 2023-08-17T09:18:21+00:00 urn:sha1:4aaa10717b193a2505cd911abb5eaaf194e54e4c This also avoids more undefined behavior with memcmp(). ok jsing PS: Unsolicited advice for no one in particular: there is this awesome tool called grep. If someone reports an issue, you might want to use it to find more instances. Avoid memcmp(NULL, x, 0) in OBJ_cmp() 2023-08-17T09:13:01+00:00 tb 2023-08-17T09:13:01+00:00 urn:sha1:6471b8f7fa3b39cc42e96f0ab3cfb2ea11a226c5 If a->length is 0, either a->data or b->data could be NULL and memcmp() will rely on undefined behavior to compare them as equal. So avoid this comparison in the first place. ok jsing Remove OBJ_add_sigid() and OBJ_sigid_free() 2023-07-28T10:25:05+00:00 tb 2023-07-28T10:25:05+00:00 urn:sha1:ff3b404e5cda0d0876bf6dccdcc293d75dd12c57 Another bit of unused extensibility that was responsible for a lot of complexity until recently. This removes the remaining stubs from the public API. ok jsing Align argument names of OBJ_add_sigid() with the other functions. 2023-07-22T19:08:03+00:00 tb 2023-07-22T19:08:03+00:00 urn:sha1:50f4fc20401c6f47f0efdb5dde0e8b49e7769f77