openbsd/src/lib/libcrypto/ocsp, branch libressl-v2.1.2 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v2.1.2 2014-10-28T05:46:56+00:00 Check the result of sk_*_push() operations for failure. 2014-10-28T05:46:56+00:00 miod 2014-10-28T05:46:56+00:00 urn:sha1:794dcf073b734d649d7b5d30916d7a3ae919b66e ok doug@ jsing@ Use arc4random_buf() instead of RAND_bytes() or RAND_pseudo_bytes(). 2014-10-22T13:02:04+00:00 jsing 2014-10-22T13:02:04+00:00 urn:sha1:fa457604779ff38b511fdfdae3c6a78664281c22 arc4random_buf() is guaranteed to always succeed - it is worth noting that a number of the replaced function calls were already missing return value checks. ok deraadt@ None of these need to include <openssl/rand.h> 2014-10-18T17:20:40+00:00 jsing 2014-10-18T17:20:40+00:00 urn:sha1:0bad55f54f7132a386746f23ba4f2d106d115563 Use string literals in printf style calls so gcc's -Wformat works. 2014-10-03T06:02:38+00:00 doug 2014-10-03T06:02:38+00:00 urn:sha1:3e3e62d53cc575a61b99b211f05e78229c836866 ok tedu@, miod@ BIO_free() returns immediately when the sole input is NULL. 2014-07-25T06:05:32+00:00 doug 2014-07-25T06:05:32+00:00 urn:sha1:d9473bfc95b9bc3edd71f25c11f0b47b27500df9 Remove unnecessary NULL check. ok miod@ The bell tolls for BUF_strdup - Start the migration to using 2014-07-13T16:03:10+00:00 beck 2014-07-13T16:03:10+00:00 urn:sha1:c7e9c2c6576cd5406680f9b69aff2038ba63b0dc intrinsics. This is the easy ones, a few left to check one at a time. ok miod@ deraadt@ Principle of least surprise: make CMAC_CTX_free(), OCSP_REQ_CTX_free() and 2014-07-12T14:58:32+00:00 miod 2014-07-12T14:58:32+00:00 urn:sha1:19a19b8eff7c4c610f87ca07a02612af9017c9d9 X509_STORE_CTX_free() accept NULL pointers as input without dereferencing them, like all the other well-behaved *_CTX_free() functions do. Only import cryptlib.h in the four source files that actually need it. 2014-07-11T08:44:49+00:00 jsing 2014-07-11T08:44:49+00:00 urn:sha1:74e2c009c83ad374bd6acdcfc376a384e25ab007 Remove the openssl public includes from cryptlib.h and add a small number of includes into the source files that actually need them. While here, also sort/group/tidy the includes. ok beck@ miod@ Explicitly include <openssl/opensslconf.h> in every file that references 2014-07-10T22:45:58+00:00 jsing 2014-07-10T22:45:58+00:00 urn:sha1:62348213609ef233110561d1a6ed67ad66df1c7e an OPENSSL_NO_* define. This avoids relying on something else pulling it in for us, plus it fixes several cases where the #ifndef OPENSSL_NO_XYZ is never going to do anything, since OPENSSL_NO_XYZ will never defined, due to the fact that opensslconf.h has not been included. This also includes some miscellaneous sorting/tidying of headers. Stop including standard headers via cryptlib.h - pull in the headers that 2014-07-10T13:58:23+00:00 jsing 2014-07-10T13:58:23+00:00 urn:sha1:c917c683bc93c68fbf4310ac181f7906e76b3c94 are needed in the source files that actually require them. ok beck@ miod@