openbsd/src/lib/libcrypto/pem/pvkfmt.c, branch OPENBSD_7_9_BASE

do_PVK_body: Unconditionally free enctmp

2025-06-07T09:32:35+00:00

enctmp is only allocated if saltlen > 0, so there is no harm in checking for that, but it's also pointless. Unconfuses smatch who thinks there might be a memory leak: pem/pvkfmt.c:808 do_PVK_body() warn: possible memory leak of 'enctmp' found by jsg

Use err_local.h rather than err.h in most places

2025-05-10T05:54:39+00:00

ok jsing

Use EVP_MD_CTX_legacy_clear() internally

2024-02-18T15:45:42+00:00

ok jsing

Hide symbols in lhash, pem, and rc2

2023-07-07T13:40:44+00:00

ok jsing@

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Prepare to make RSA and RSA_METHOD opaque by including rsa_locl.h

2022-01-07T09:55:32+00:00

where it will be needed in the upcoming bump. discussed with jsing

Prepare the move of DSA_SIG, DSA_METHOD and DSA to dsa_locl.h by

2022-01-07T09:35:36+00:00

including the local header where it will be needed. discussed with jsing

Include evp_locl.h where it will be needed once most structs from

2021-12-12T21:30:14+00:00

evp.h will be moved to evp_locl.h in an upcoming bump. ok inoguchi

Clean up pvkfmt.c

2019-07-08T11:56:18+00:00

- Replace EVP_CIPHER_CTX_init with EVP_CIPHER_CTX_new and handle return value - Replace EVP_CIPHER_CTX_cleanup with EVP_CIPHER_CTX_free - Change two 'return -1;' to 'goto err;' for avoiding leak - Remove the case if enclevel == 0 - Change enclevel checking to make more consistent - Change all goto label to 'err' and insert space before goto label ok and advise from tb@

Fix pvk format processing in libcrypto

2019-07-07T10:52:56+00:00

- Return the valid pointer in i2b_PVK() - Use EVP_Decrypt* instead of EVP_Encrypt* - Fix error handling after BIO_write() in i2b_PVK_bio() ok tb@