openbsd/src/lib/libcrypto/pem, branch OPENBSD_6_4_BASE A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_6_4_BASE 2018-08-24T19:51:31+00:00 Change PEM_Sign{Init,Update}() to return an int. 2018-08-24T19:51:31+00:00 tb 2018-08-24T19:51:31+00:00 urn:sha1:bf5473ed3db3f13d45280ab553b3c593d8e311ea tested in a bulk by sthen ok jsing Check return value of EVP_EncodeUpdate() in PEM_write_bio(). 2018-08-24T19:48:39+00:00 tb 2018-08-24T19:48:39+00:00 urn:sha1:f7f51b71b683001b12ec548a55a6c0779df009d5 ok jsing Fix memory leak in i2b_PVK in error handling. 2018-08-05T11:19:25+00:00 bcook 2018-08-05T11:19:25+00:00 urn:sha1:2e290efb0ac101817d9da88a5b417f1b48cbe3fa Simplify parameter checks since this is only called from one place. Found by Coverity, CID 183502. ok beck@ Add const qualifier to the 'name', 'header', and 'data' arguments of 2018-05-13T10:47:54+00:00 tb 2018-05-13T10:47:54+00:00 urn:sha1:3b290073d5397f3c36a8cdf72764dc9bed6c5ebd PEM_write(3) and PEM_write_bio(3). tested in a bulk build by sthen ok jsing make ENGINE_finish() succeed on NULL and simplify callers as in 2018-04-14T07:09:21+00:00 tb 2018-04-14T07:09:21+00:00 urn:sha1:0c5418014797b1fadca3f270eb2f140fd6f5bdf8 OpenSSL commit 7c96dbcdab9 by Rich Salz. This cleans up the caller side quite a bit and reduces the number of lines enclosed in #ifndef OPENSSL_NO_ENGINE. codesearch.debian.net shows that almost nothing checks the return value of ENGINE_finish(). While there, replace a few nearby 'if (!ptr)' with 'if (ptr == NULL)'. ok jsing, tested by & ok inoguchi use freezero() instead of memset/explicit_bzero + free. Substantially 2017-05-02T03:59:45+00:00 deraadt 2017-05-02T03:59:45+00:00 urn:sha1:5904cc0e04409fde39a97e6580535da34eeb4291 reduces conditional logic (-218, +82). MOD_EXP_CTIME_MIN_CACHE_LINE_WIDTH cache alignment calculation bn/bn_exp.c wasn'tt quite right. Two other tricky bits with ASN1_STRING_FLAG_NDEF and BN_FLG_STATIC_DATA where the condition cannot be collapsed completely. Passes regress. ok beck Send the function codes from the error functions to the bit bucket, 2017-01-29T17:49:23+00:00 beck 2017-01-29T17:49:23+00:00 urn:sha1:d1f47bd292f36094480caa49ada36b99a69c59b0 as was done earlier in libssl. Thanks inoguchi@ for noticing libssl had more reacharounds into this. ok jsing@ inoguchi@ Make explicit _ct and _nonct versions of bn_mod_exp funcitons that 2017-01-21T09:38:59+00:00 beck 2017-01-21T09:38:59+00:00 urn:sha1:a0a595cda97de2b217b0582cfa601ee4c746bfce matter for constant time, and make the public interface only used external to the library. This moves us to a model where the important things are constant time versions unless you ask for them not to be, rather than the opposite. I'll continue with this method by method. Add regress tests for same. ok jsing@ Make sure PEM_SealInit() will correctly destroy the PEM_ENCODE_SEAL_CTX 2016-11-05T11:32:45+00:00 miod 2016-11-05T11:32:45+00:00 urn:sha1:ffd43b659f17d59a2d2db62b9eb10f47c783643c upon error, as there is no way to do this outside of PEM_SealFinal(), which can only work if PEM_SealInit() succeeded... ok beck@ jsing@ unifdef OPENSSL_NO_CMS 2016-10-19T16:49:11+00:00 jsing 2016-10-19T16:49:11+00:00 urn:sha1:2a3b8c956b102b5686a0e8569612a0edb275f365