A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_7 2024-06-24T06:43:23+00:00 2024-06-24T06:43:23+00:00 tb 2024-06-24T06:43:23+00:00 urn:sha1:c9802a5afe29675d69b605ce906d34fd89c024ac These constitute the bulk of the remaining global mutable state in libcrypto. This commit moves most of them into data.rel.ro, leaving out ERR_str_{functs,libraries,reasons} (which require a slightly different approach) and SYS_str_reasons which is populated on startup. The main observation is that if ERR_load_strings() is called with a 0 lib argument, the ERR_STRING_DATA argument is not actually modified. We could use this fact to cast away const on the caller side and be done with it. We can make this cleaner by adding a helper ERR_load_const_strings() which explicitly avoids the assignment to str->error overriding the error code already set in the table. In order for this to work, we need to sprinkle some const in err/err.c. CMS called ERR_load_strings() with non-0 lib argument, but this didn't actually modify the error data since it ored in the value already stored in the table. Annoyingly, we need to cast const away once, namely in the call to lh_insert() in int_err_set_item(). Fixing this would require changing the public API and is going to be tricky since it requires that the LHASH_DOALL_FN_* types adjust. ok jsing 2024-05-11T05:41:28+00:00 tb 2024-05-11T05:41:28+00:00 urn:sha1:a3317d944cfde852481cdb5788240469a51cce9b I could not find any use of this in all of OpenSSL's git history since SSLeay 0.8.1b. ok jsing 2024-04-25T16:14:00+00:00 tb 2024-04-25T16:14:00+00:00 urn:sha1:1820318c4dea1e9102a0d5ebae1e810a9886ea24 /* * This header only exists to break a circular dependency between pem and err * Ben 30 Jan 1999. */ 25 years of uselessness is about a quarter century more than enough. discussed with jsing 2024-03-29T02:22:18+00:00 jsing 2024-03-29T02:22:18+00:00 urn:sha1:d4b7d2c84449fd144c1078f6ab2f9ca24691cdeb Somewhere in the past 25 years, the circular dependency between err and pem went away. Stop pulling in pem2.h and just use pem.h directly (pem2.h can probably be removed at some point, but that remains for another day). ok joshua@ tb@ 2024-02-18T15:45:42+00:00 tb 2024-02-18T15:45:42+00:00 urn:sha1:ff3e386de60f6149938edb124d31bc2fd7ae04f6 ok jsing 2024-02-18T15:44:10+00:00 tb 2024-02-18T15:44:10+00:00 urn:sha1:f941ba215d7859bf6c6225e88cbbe13260428b8c ok jsing 2023-11-29T21:35:57+00:00 tb 2023-11-29T21:35:57+00:00 urn:sha1:69bbc5fea4f411f0c0033ecb0fc5126c895ea82a This removes the remaining ENGINE members from various internal structs and functions. Any ENGINE passed into a public API is now completely ignored functions returning an ENGINE always return NULL. ok jsing 2023-11-19T15:46:10+00:00 tb 2023-11-19T15:46:10+00:00 urn:sha1:593d97e74cc873d99aced677883cf55625efe62d This is mechanical apart from a few manual edits to avoid doubled empty lines. ok jsing 2023-07-07T13:40:44+00:00 beck 2023-07-07T13:40:44+00:00 urn:sha1:1355f5b75c135c6bbe53ddedd21c86e2952b9895 ok jsing@ 2023-04-25T17:51:36+00:00 tb 2023-04-25T17:51:36+00:00 urn:sha1:73801d916399112cd98e764eed5d739f168d2a8f