openbsd/src/lib/libcrypto/pkcs12, branch libressl-v2.1.2 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v2.1.2 2014-10-22T18:37:22+00:00 In PKCS12_setup_mac(), do not assign p12->mac->salt->length until the allocation 2014-10-22T18:37:22+00:00 miod 2014-10-22T18:37:22+00:00 urn:sha1:769d991f45bfb5268c116c67f72e2376c8439501 of p12->mac->salt->data has actually succeeded. In one of my trees for a long time already... Use arc4random_buf() instead of RAND_bytes() or RAND_pseudo_bytes(). 2014-10-22T13:02:04+00:00 jsing 2014-10-22T13:02:04+00:00 urn:sha1:fa457604779ff38b511fdfdae3c6a78664281c22 arc4random_buf() is guaranteed to always succeed - it is worth noting that a number of the replaced function calls were already missing return value checks. ok deraadt@ if (x) FOO_free(x) -> FOO_free(x). 2014-07-12T16:03:37+00:00 miod 2014-07-12T16:03:37+00:00 urn:sha1:068bf464df6ef084067943863d776f59762bfaf0 Improves readability, keeps the code smaller so that it is warmer in your cache. review & ok deraadt@ Only import cryptlib.h in the four source files that actually need it. 2014-07-11T08:44:49+00:00 jsing 2014-07-11T08:44:49+00:00 urn:sha1:74e2c009c83ad374bd6acdcfc376a384e25ab007 Remove the openssl public includes from cryptlib.h and add a small number of includes into the source files that actually need them. While here, also sort/group/tidy the includes. ok beck@ miod@ Explicitly include <openssl/opensslconf.h> in every file that references 2014-07-10T22:45:58+00:00 jsing 2014-07-10T22:45:58+00:00 urn:sha1:62348213609ef233110561d1a6ed67ad66df1c7e an OPENSSL_NO_* define. This avoids relying on something else pulling it in for us, plus it fixes several cases where the #ifndef OPENSSL_NO_XYZ is never going to do anything, since OPENSSL_NO_XYZ will never defined, due to the fact that opensslconf.h has not been included. This also includes some miscellaneous sorting/tidying of headers. Stop including standard headers via cryptlib.h - pull in the headers that 2014-07-10T13:58:23+00:00 jsing 2014-07-10T13:58:23+00:00 urn:sha1:c917c683bc93c68fbf4310ac181f7906e76b3c94 are needed in the source files that actually require them. ok beck@ miod@ One sure hopes that OPENSSL_cleanse will: 2014-07-10T12:09:43+00:00 jsing 2014-07-10T12:09:43+00:00 urn:sha1:ccef1207ba0271ed19ecd005e1ce6ec7093d7839 /* Clear password from memory */ Remove DEBUG_KEYGEN and DEBUG_DECRYPT support. 2014-07-10T10:01:23+00:00 miod 2014-07-10T10:01:23+00:00 urn:sha1:f8d4454abafbf877eaa4743a35e456e759d3acc9 KNF. 2014-07-08T09:27:21+00:00 jsing 2014-07-08T09:27:21+00:00 urn:sha1:d3dceafe46f05ecfc9d781a93e80e2dc3f3e74dd tags as requested by miod and tedu 2014-06-12T15:49:31+00:00 deraadt 2014-06-12T15:49:31+00:00 urn:sha1:59f4f2c61d71e266d37dd2fc97615b3fd35b4721