openbsd/src/lib/libcrypto/pkcs12, branch libressl-v2.1.4A mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=libressl-v2.1.42015-02-14T14:18:58+00:00Attempt to correctly free temporary storage upon error. With help from2015-02-14T14:18:58+00:00miod2015-02-14T14:18:58+00:00urn:sha1:15b45e3bec309990789c2328654c0474039528ae
doug@ and jsing@, ok doug@ three months ago (sigh... I sometimes suck bigtime
at commiting bugfixes)
Try and fix a bunch of memory leaks upon error;2015-02-14T12:43:07+00:00miod2015-02-14T12:43:07+00:00urn:sha1:16bf6fbfcc2a62c9ce5fb76c2f7f00b9b214d5c1
ok tedu@ about 7 months ago and I was sitting upon this diff for no reason
Expand the IMPLEMENT_ASN1_FUNCTIONS macro so that the code is visible and2015-02-09T16:04:46+00:00jsing2015-02-09T16:04:46+00:00urn:sha1:4fb19543f9f5f3b5e26820a0dfdffa75a332314d
functions can be readily located.
Change has been scripted and there is no change to the generated assembly.
Discussed with beck@ miod@ tedu@
Delete a lot of #if 0 code in libressl.2015-02-07T13:19:15+00:00doug2015-02-07T13:19:15+00:00urn:sha1:a58e958ffece1b48f50bc090357dee2cd5b1bc20
There are a few instances where #if 1 is removed but the code remains.
Based on the following OpenSSL commits. Some of the commits weren't
strictly deletions so they are going to be split up into separate commits.
6f91b017bbb7140f816721141ac156d1b828a6b3
3d47c1d331fdc7574d2275cda1a630ccdb624b08
dfb56425b68314b2b57e17c82c1df42e7a015132
c8fa2356a00cbaada8963f739e5570298311a060
f16a64d11f55c01f56baa62ebf1dec7f8fe718cb
9ccc00ef6ea65567622e40c49aca43f2c6d79cdb
02a938c953b3e1ced71d9a832de1618f907eb96d
75d0ebef2aef7a2c77b27575b8da898e22f3ccd5
d6fbb194095312f4722c81c9362dbd0de66cb656
6f1a93ad111c7dfe36a09a976c4c009079b19ea1
1a5adcfb5edfe23908b350f8757df405b0f5f71f
8de24b792743d11e1d5a0dcd336a49368750c577
a2b18e657ea1a932d125154f4e13ab2258796d90
8e964419603d2478dfb391c66e7ccb2dcc9776b4
32dfde107636ac9bc62a5b3233fe2a54dbc27008
input + ok jsing@, miod@, tedu@
In PKCS12_setup_mac(), do not assign p12->mac->salt->length until the allocation2014-10-22T18:37:22+00:00miod2014-10-22T18:37:22+00:00urn:sha1:769d991f45bfb5268c116c67f72e2376c8439501
of p12->mac->salt->data has actually succeeded.
In one of my trees for a long time already...
Use arc4random_buf() instead of RAND_bytes() or RAND_pseudo_bytes().2014-10-22T13:02:04+00:00jsing2014-10-22T13:02:04+00:00urn:sha1:fa457604779ff38b511fdfdae3c6a78664281c22
arc4random_buf() is guaranteed to always succeed - it is worth noting
that a number of the replaced function calls were already missing return
value checks.
ok deraadt@
if (x) FOO_free(x) -> FOO_free(x).2014-07-12T16:03:37+00:00miod2014-07-12T16:03:37+00:00urn:sha1:068bf464df6ef084067943863d776f59762bfaf0
Improves readability, keeps the code smaller so that it is warmer in your
cache.
review & ok deraadt@
Only import cryptlib.h in the four source files that actually need it.2014-07-11T08:44:49+00:00jsing2014-07-11T08:44:49+00:00urn:sha1:74e2c009c83ad374bd6acdcfc376a384e25ab007
Remove the openssl public includes from cryptlib.h and add a small number
of includes into the source files that actually need them. While here,
also sort/group/tidy the includes.
ok beck@ miod@
Explicitly include <openssl/opensslconf.h> in every file that references2014-07-10T22:45:58+00:00jsing2014-07-10T22:45:58+00:00urn:sha1:62348213609ef233110561d1a6ed67ad66df1c7e
an OPENSSL_NO_* define. This avoids relying on something else pulling it
in for us, plus it fixes several cases where the #ifndef OPENSSL_NO_XYZ is
never going to do anything, since OPENSSL_NO_XYZ will never defined, due
to the fact that opensslconf.h has not been included.
This also includes some miscellaneous sorting/tidying of headers.
Stop including standard headers via cryptlib.h - pull in the headers that2014-07-10T13:58:23+00:00jsing2014-07-10T13:58:23+00:00urn:sha1:c917c683bc93c68fbf4310ac181f7906e76b3c94
are needed in the source files that actually require them.
ok beck@ miod@