openbsd/src/lib/libcrypto/pkcs12, branch libressl-v3.3.5 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v3.3.5 2020-06-05T16:51:12+00:00 Remove remaining error *_str_functs[] 2020-06-05T16:51:12+00:00 jsing 2020-06-05T16:51:12+00:00 urn:sha1:6aa0c4f1ec702bb2c820322709abd9c1767842fa A number of years ago we dropped the concept of having function names in errors, since it is not that useful and very quickly gets out of sync when refactoring. It would seem that some new ones got imported and some missed the last clean up. ok tb@ beck@ "kill it with fire" Remove EVP_PKEY2PKCS8_broken() and PKCS8_set_broken() 2018-08-24T20:07:42+00:00 tb 2018-08-24T20:07:42+00:00 urn:sha1:e4cf8ac5385c963bee0eb8d0e642abe1bb82ac78 Provide PKCS8_pkey_add1_attr_by_NID() and PKCS8_pkey_get0_attrs(). Remove the whole broken code and simplify pkcs8_priv_key_info_st accordingly. Based on OpenSSL commit 54dbf42398e23349b59f258a3dd60387bbc5ba13 plus some const that was added later. tested in a bulk build by sthen ok jsing Add a const qualifier to the `uni' argument of OPENSSL_uni2asc(). 2018-05-30T15:32:11+00:00 tb 2018-05-30T15:32:11+00:00 urn:sha1:87588ca5f85a92585105f886faa049e39b3feb2c tested in a bulk build by sthen ok jsing Add const qualifiers to the X509_SIG * and char * arguments of 2018-05-13T14:28:14+00:00 tb 2018-05-13T14:28:14+00:00 urn:sha1:831f973c7d650b6943f7f3ad3e4e1c2ac59ac34b PKCS8_decrypt(3). tested in a bulk build by sthen ok beck, jsing Add const to the argument of PKCS12_pack_authsafes(3). 2018-05-13T14:24:07+00:00 tb 2018-05-13T14:24:07+00:00 urn:sha1:0eaf185427c2459ff767ff8fabeef9ea26aa02c6 tested in a bulk by sthen ok beck, jsing Add const to the X509_ALGOR and other arguments of 2018-05-13T14:22:34+00:00 tb 2018-05-13T14:22:34+00:00 urn:sha1:386df0807ac92c64c0392775378e1b196e0199a4 PKCS12_item_decrypt_d2i(3), PKCS12_pbe_crypt(3), PKCS12_newpass(3). tested in a bulk by sthen ok beck, jsing Add const to the attr argument of PKCS12_get_attr_gen(3). 2018-05-13T14:15:01+00:00 tb 2018-05-13T14:15:01+00:00 urn:sha1:0136b9792212398e618ee46e35bbe85cbd696a87 tested in a bulk by sthen ok beck, jsing Add const qualifier to the PKCS12_SAFEBAG argument of 2018-05-13T13:51:22+00:00 tb 2018-05-13T13:51:22+00:00 urn:sha1:d64f477001df60c386bd5343d3a5d756f29fdc70 PKCS12_decrypt_skey(3). tested in a bulk by sthen ok beck, jsing Add const qualifiers to the 'pass' and 'name' arguments of 2018-05-13T13:46:55+00:00 tb 2018-05-13T13:46:55+00:00 urn:sha1:1903f850c0769bfd90bc9627f2e910d7c2ce4ccd PKCS12_add_key(3), PKCS12_add_safe(3), PKCS12_create(3). tested in a bulk build by sthen ok beck, jsing use freezero() instead of memset/explicit_bzero + free. Substantially 2017-05-02T03:59:45+00:00 deraadt 2017-05-02T03:59:45+00:00 urn:sha1:5904cc0e04409fde39a97e6580535da34eeb4291 reduces conditional logic (-218, +82). MOD_EXP_CTIME_MIN_CACHE_LINE_WIDTH cache alignment calculation bn/bn_exp.c wasn'tt quite right. Two other tricky bits with ASN1_STRING_FLAG_NDEF and BN_FLG_STATIC_DATA where the condition cannot be collapsed completely. Passes regress. ok beck