openbsd/src/lib/libcrypto/pkcs12, branch libressl-v3.8.0

libressl _namespace.h: adjust _ALIAS() to require a semicolon

2023-02-16T08:38:17+00:00

LCRYPTO_ALIAS() and LSSL_ALIAS() contained a trailing semicolon. This does not conform to style(9), breaks editors and ctags and (most importantly) my workflow. Fix this by neutering them with asm("") so that -Wpedantic doesn't complain. There's precedent in libc's namespace.h fix suggested by & ok jsing

Check return value of X509_digest

2023-01-24T09:48:57+00:00

OK tb@

Make header guards of internal headers consistent

2022-11-26T17:23:18+00:00

Not all of them, only those that didn't leak into a public header... Yes.

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Hide symbols in libcrypto/pkcs12

2022-11-12T13:03:28+00:00

ok jsing@

Make structs in pkcs12.h opaque

2022-09-11T17:30:13+00:00

ok jsing

Add an empty pkcs12_local.h and include it where it will soon be needed.

2022-08-20T09:16:18+00:00

Prepare to provide PKCS12 accessors

2022-08-03T20:16:06+00:00

In order to be able to make pkcs12/ opaque, we need an entire family of accessors. These are in a particularly nasty tangle since this was done in about a dozen steps while sprinkling const, renaming functions, etc. The public API also adds backward compat macros for functions that were in the tree for half a day and then renamed. Of course some of them got picked up by some ports. Some of the gruesome hacks in here will go away with the next bump, but that doesn't mean that the pkcs12 directory will be prettier afterward. ok jsing

Eliminate the somewhat pointless Ij variable

2022-07-30T11:27:06+00:00

Requested by & ok jsing

Transform two || chains into individually checked functions

2022-07-30T11:24:52+00:00

Requested by and ok jsing