openbsd/src/lib/libcrypto/pkcs12, branch masterA mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=master2026-01-27T14:14:20+00:00Avoid type confusion in PKCS#12 parsing2026-01-27T14:14:20+00:00tb2026-01-27T14:14:20+00:00urn:sha1:80b52a32d57440334a364d1c23155c87f46f2831
A type confusion can lead to a 1-byte read at address 0x00-0xff, so a
crash.
Reported by Luigino Camastra, fix by Bob Beck, via OpenSSL, CVE 2025-22795
ok jsing
Add NULL pointer check to PKCS12_item_decrypt_d2i()2026-01-27T14:03:01+00:00tb2026-01-27T14:03:01+00:00urn:sha1:81617536ce695a5b2c65926fbe0b3b14466d95b6
Avoids a NULL pointer dereference triggerable by a malformed PCKS#12 file.
From Luigino Camastra via OpenSSL (CVE-2025-69421)
ok jsing
Use timingsafe_memcmp when comparing authenticators2025-06-03T08:42:15+00:00kenjiro2025-06-03T08:42:15+00:00urn:sha1:0fc5b6d312fea35d788e92ffc5a6dc32638d32bc
Replace memcmp() with timingsafe_memcmp() for authentication tag
comparison in AES-CCM, GCM, PKCS12 and AES key unwrap code paths
to ensure constant-time behavior and avoid potential timing side
channels.
This aligns with OpenSSL 1e4a355.
ok tb@
Increase default PKCS12_SALT_LEN from 8 to 16 bytes2025-05-10T19:01:16+00:00tb2025-05-10T19:01:16+00:00urn:sha1:5747076436203e94cc042d06e2a8ae46b0ea5a47
Currently PKCS12_setup_mac() function uses salt length of 8 bytes / 64
bits when no salt length is specified. Increase this fallback default
to 16 bytes / 128 bits, as recommended by NIST SP 800-132.
Note this is for interoperability purposes. Some FIPS implementations
enforce minimum salt length of 16 bytes. Examples of such FIPS
implemenations are Bouncycastle FIPS Java API and Chainguard FIPS
Provider for OpenSSL. Also future v3.6 release of OpenSSL will also
increase the default salt length to 16 bytes.
From Dimitri John Ledkov, thanks
Use err_local.h rather than err.h in most places2025-05-10T05:54:39+00:00tb2025-05-10T05:54:39+00:00urn:sha1:41e8f99dd1625a9f0c80ce9d4383e95b18e85709
ok jsing
Reinstate PKCS12_key_gen_uni()2025-03-09T15:45:52+00:00tb2025-03-09T15:45:52+00:00urn:sha1:9971249d16e9e04b0af48f612febcd91710abad9
Unfortunately, this is used in acsm-calibre-plugin, via oscrypto.
Fixes https://github.com/Leseratte10/acsm-calibre-plugin/issues/112
ok jsing
unitialized -> uninitialized2025-01-06T23:35:25+00:00tb2025-01-06T23:35:25+00:00urn:sha1:f62644a3fec4a1c2ba18134913f454106247493dRemove copy_bag_attr()2024-08-22T12:22:42+00:00tb2024-08-22T12:22:42+00:00urn:sha1:de9723d006cceb5ae0915a4891de3155c9232629
It is no longer possible to set an attribute on an EVP_PKEY, so this
code is dead.
ok miod
Fix PKCS12_create()2024-07-15T15:43:25+00:00tb2024-07-15T15:43:25+00:00urn:sha1:beafda5998db0cbb734723cf1f2897bbf6046bdb
This tries to copy some microsoft attributes which are not usually present
and chokes on the now disabled EVP_PKEY_*attr* API. Instead of reviving
about four layers of traps and indirection, just inline the two functions
in a way that should be more obvious.
found by anton via the ruby-openssl tests
ok jsing
Hide global _it symbols in pkcs12.h2024-07-09T06:13:22+00:00beck2024-07-09T06:13:22+00:00urn:sha1:a40dc77f12153071625af9215f01a8be78a4539a
ok tb@