openbsd/src/lib/libcrypto/pkcs7, branch libressl-v2.9.2 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v2.9.2 2019-03-13T20:34:00+00:00 Fix a number of ASN1_INTEGER vs ASN1_STRING mixups coming from the 2019-03-13T20:34:00+00:00 tb 2019-03-13T20:34:00+00:00 urn:sha1:5ac8b80c66d7d9f6dab1bfdf23f0578eb05dffa0 mechanical M_ASN1 macro expansion. The ASN1_INTEGER_cmp function takes signs into account while ASN1_STRING_cmp doesn't. The mixups mostly involve serialNumbers, which, in principle, should be positive. However, it is unclear whether that is checked or enforced anywhere in the code, so these are probably bugs. Patch from Holger Mikolon ok jsing use freezero() instead of memset/explicit_bzero + free. Substantially 2017-05-02T03:59:45+00:00 deraadt 2017-05-02T03:59:45+00:00 urn:sha1:5904cc0e04409fde39a97e6580535da34eeb4291 reduces conditional logic (-218, +82). MOD_EXP_CTIME_MIN_CACHE_LINE_WIDTH cache alignment calculation bn/bn_exp.c wasn'tt quite right. Two other tricky bits with ASN1_STRING_FLAG_NDEF and BN_FLG_STATIC_DATA where the condition cannot be collapsed completely. Passes regress. ok beck Send the function codes from the error functions to the bit bucket, 2017-01-29T17:49:23+00:00 beck 2017-01-29T17:49:23+00:00 urn:sha1:d1f47bd292f36094480caa49ada36b99a69c59b0 as was done earlier in libssl. Thanks inoguchi@ for noticing libssl had more reacharounds into this. ok jsing@ inoguchi@ Expand ASN1_ITEM_rptr macros - no change in generated assembly. 2016-12-30T15:38:13+00:00 jsing 2016-12-30T15:38:13+00:00 urn:sha1:d4b09bfd41d8d40b82b197b4ec8b0232cd6ee1fa Expand DECLARE_ASN1_{NDEF,PRINT}_FUNCTION macros - no change in 2016-12-27T16:12:47+00:00 jsing 2016-12-27T16:12:47+00:00 urn:sha1:88eca948401bc84800904fce043f4ca513c36349 preprocesssor output. Remove all DECLARE_ASN1_SET_OF macro usage - since 2000 these have been 2016-12-27T16:05:57+00:00 jsing 2016-12-27T16:05:57+00:00 urn:sha1:0bde81f3db44da2391092cc43925c8351096c73c nothing but markers for utils/mkstack.pl... and we removed the code that generated more macros from these markers in 2014. Expand DECLARE_ASN1_ITEM - no change to preprocessor output. 2016-12-27T15:35:59+00:00 jsing 2016-12-27T15:35:59+00:00 urn:sha1:50debf61d5f52106f032525ed745d120470ca545 More X509_STORE_CTX_set_*() return value checks. 2016-11-05T15:19:07+00:00 miod 2016-11-05T15:19:07+00:00 urn:sha1:f72470bc783a016dc0f537ddde0f7868dcf634f4 ok beck@ jsing@ Expand DECLARE_ASN1_.*FUNCTIONS macros. 2016-09-04T17:25:27+00:00 jsing 2016-09-04T17:25:27+00:00 urn:sha1:6b821b77472515bca3e910c34372cf3306e435dd No change in preprocessed output, ignoring whitespace and line numbers. Replace M_ASN1_OCTET_STRING_(free|new) with ASN1_OCTET_STRING_(free|new). 2015-09-30T18:41:06+00:00 jsing 2015-09-30T18:41:06+00:00 urn:sha1:80275458dc3673baf5dc56ab2300719f4828295b