openbsd/src/lib/libcrypto/pkcs7, branch libressl-v3.2.0

Remove redundant ASN1_INTEGER_set call in PKCS7_set_type

2020-01-21T10:18:52+00:00

ok bcook@

Fix a padding oracle in PKCS7_dataDecode and CMS_decrypt_set1_pkey.

2019-10-04T18:03:56+00:00

(Note that the CMS code is currently disabled.) Port of Edlinger's Fix for CVE-2019-1563 from OpenSSL 1.1.1 (old license) tests from bluhm@ ok jsing commit e21f8cf78a125cd3c8c0d1a1a6c8bb0b901f893f Author: Bernd Edlinger Date: Sun Sep 1 00:16:28 2019 +0200 Fix a padding oracle in PKCS7_dataDecode and CMS_decrypt_set1_pkey An attack is simple, if the first CMS_recipientInfo is valid but the second CMS_recipientInfo is chosen ciphertext. If the second recipientInfo decodes to PKCS #1 v1.5 form plaintext, the correct encryption key will be replaced by garbage, and the message cannot be decoded, but if the RSA decryption fails, the correct encryption key is used and the recipient will not notice the attack. As a work around for this potential attack the length of the decrypted key must be equal to the cipher default key length, in case the certifiate is not given and all recipientInfo are tried out. The old behaviour can be re-enabled in the CMS code by setting the CMS_DEBUG_DECRYPT flag. Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/9777) (cherry picked from commit 5840ed0cd1e6487d247efbc1a04136a41d7b3a37)

Fix a number of ASN1_INTEGER vs ASN1_STRING mixups coming from the

2019-03-13T20:34:00+00:00

mechanical M_ASN1 macro expansion. The ASN1_INTEGER_cmp function takes signs into account while ASN1_STRING_cmp doesn't. The mixups mostly involve serialNumbers, which, in principle, should be positive. However, it is unclear whether that is checked or enforced anywhere in the code, so these are probably bugs. Patch from Holger Mikolon ok jsing

use freezero() instead of memset/explicit_bzero + free. Substantially

2017-05-02T03:59:45+00:00

reduces conditional logic (-218, +82). MOD_EXP_CTIME_MIN_CACHE_LINE_WIDTH cache alignment calculation bn/bn_exp.c wasn'tt quite right. Two other tricky bits with ASN1_STRING_FLAG_NDEF and BN_FLG_STATIC_DATA where the condition cannot be collapsed completely. Passes regress. ok beck

Send the function codes from the error functions to the bit bucket,

2017-01-29T17:49:23+00:00

as was done earlier in libssl. Thanks inoguchi@ for noticing libssl had more reacharounds into this. ok jsing@ inoguchi@

Expand ASN1_ITEM_rptr macros - no change in generated assembly.

2016-12-30T15:38:13+00:00

Expand DECLARE_ASN1_{NDEF,PRINT}_FUNCTION macros - no change in

2016-12-27T16:12:47+00:00

preprocesssor output.

Remove all DECLARE_ASN1_SET_OF macro usage - since 2000 these have been

2016-12-27T16:05:57+00:00

nothing but markers for utils/mkstack.pl... and we removed the code that generated more macros from these markers in 2014.

Expand DECLARE_ASN1_ITEM - no change to preprocessor output.

2016-12-27T15:35:59+00:00

More X509_STORE_CTX_set_*() return value checks.

2016-11-05T15:19:07+00:00

ok beck@ jsing@