A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_9_BASE 2025-01-25T17:59:44+00:00 2025-01-25T17:59:44+00:00 tb 2025-01-25T17:59:44+00:00 urn:sha1:5d52abc236226c5a47c36b07e2256e77141e373a discussed with jsing 2024-05-19T07:12:50+00:00 jsg 2024-05-19T07:12:50+00:00 urn:sha1:9dd363a8109e5383b08891f9d0307a5d5aa2bc09 feedback and ok tb@ 2023-07-28T10:05:16+00:00 tb 2023-07-28T10:05:16+00:00 urn:sha1:8f7aef795a81efc6cca2f7503141e0fddb4358c1 RSA is pretty bad. In my most optimistic moments I dream of a world that stopped using it. That won't happen during my lifetime, unfortunately. Blinding is one way of making it a little less leaky. Unfortunately this side-channel leak mitigation leaked out of the library for no good reason. Let's at least fix that aspect of it. ok jsing 2023-05-05T12:30:40+00:00 tb 2023-05-05T12:30:40+00:00 urn:sha1:8ea4c2a512bf29a8ba458782be6c1306906080ec 2023-04-25T16:50:33+00:00 tb 2023-04-25T16:50:33+00:00 urn:sha1:6d1b09464d90372ecff93cbb2a1e61cb9de814cc ok jsing 2023-04-18T08:47:28+00:00 tb 2023-04-18T08:47:28+00:00 urn:sha1:34eb49714b89be6d0c4cddab0bcab8580b6ca809 Requested by jsing 2023-04-18T08:33:43+00:00 tb 2023-04-18T08:33:43+00:00 urn:sha1:7c140db45f1d1b8f4daf0a81424b35e3a5ff8e29 Some headers were included conditionally on OPENSSL_NO_DEPRECATED in hopes that eventually the mess of everything includes everything will magically resolve itself. Of course everyone would end up building openssl with OPENSSL_NO_DEPRECATED over time... Right. Surprisingly, the ecosystem has come to rely on these implicit inclusions, so about two dozen ports would fail to build because of this. Patching this would be easy but really not worth the effort. ok jsing 2023-04-15T18:44:17+00:00 tb 2023-04-15T18:44:17+00:00 urn:sha1:95868339c86e594d93142ad6781d7e0d49a93c4d This wraps the three public functions in the usual #if stanza. RSA_X931_PADDING is unfortunately exposed by rust-openssl and erlang. Therefore it will remain visible to avoid breaking the build of lang/rust. Its use in the library will be neutered shortly. ok jsing 2023-04-09T19:10:23+00:00 tb 2023-04-09T19:10:23+00:00 urn:sha1:180ac4430773db8fb86b3343279cc5790eee08e6 Geoff Thorpe added OPENSSL_NO_DEPRECATED nearly two decades ago. The hope was that at some point some functions can be dropped. Most of the functions marked deprecated are actually unused nowadays but unfortunately some of them are still used in the ecosystem. Move them out of OPENSSL_NO_DEPRECATED so we can define it without breaking the consumers in the next bump. ERR_remove_state() is still used by a dozen or so ports. This isn't a big deal since it is just a stupid wrapper for the not quite as deprecated ERR_remove_thread_state(). It's not worth patching these ports. Annoyingly, {DH,DSA}_generate_parameters() and RSA_generate_key() are still used. They "make use" of the old-style BN_GENCB callback, which is therefore more difficult to remove - in case you don't know know: that's the thing responsible for printing pretty '.', '+' and '*' when you generate keys. Most annoyingly, DH_generate_parameters() was added to rust-openssl in 2020 for "advanced DH support". This is very unfortunate since cargo bundles a rust-openssl and updates it only every few years or so. As a consequence we're going to be stuck with this nonsense for a good while. ok beck jsing 2022-07-12T14:42:50+00:00 kn 2022-07-12T14:42:50+00:00 urn:sha1:89e42d5857196a8071fbafb5565388d0e20ec32b This script is not used at all and files are edited by hand instead. Thus remove misleading comments incl. the obsolete script/config. Feedback OK jsing tb