openbsd/src/lib/libcrypto/rsa/rsa_gen.c, branch OPENBSD_7_9_BASE

libcrypto: rsa gen: min. distance between p and q

2025-09-29T08:46:15+00:00

This is required in NIST Special Publication 800-56B Revision 2 "Recommendation for Pair-Wise Key Establishment Using Integer Factorization Cryptography": 6 RSA Key Pairs 6.2 Criteria for RSA Key Pairs for Key Establishment 6.2.1 Definition of a Key Pair 3. The prime factors p and q shall be generated using one of the methods specified in Appendix B.3 of FIPS 186 such that: c. |p – q| > 2nBits/2−100 ok djm@, tb@

Use err_local.h rather than err.h in most places

2025-05-10T05:54:39+00:00

ok jsing

Hide symbols in rsa

2023-07-08T12:26:45+00:00

ok tb@

The NBs have been duly noted and ignored. Drop them.

2023-04-13T15:18:29+00:00

Move RSA_generate_key() from rsa_depr.c to rsa_gen.c

2023-04-13T14:59:13+00:00

Discussed with jsing

Convert BN_copy() with missing error checks to bn_copy()

2023-03-27T10:22:47+00:00

ok jsing

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Fix check for BN_mod_inverse_ct return value

2022-01-20T11:12:14+00:00

ok jsing@ millert@ tb@

Prepare to make RSA and RSA_METHOD opaque by including rsa_locl.h

2022-01-07T09:55:32+00:00

where it will be needed in the upcoming bump. discussed with jsing

Consistently call BN_init() before BN_with_flags()

2021-12-26T15:16:50+00:00

BN_with_flags() preserves the BN_FLG_MALLOCED flag of the destination which results in a potential use of an uninitialized bit. In practice this doesn't matter since we don't free the cloned BIGNUMs anyway. As jsing points out, these are mostly pointless noise and should be garbage collected. I'll leave that for another rainy day. Coverity flagged one instance BN_gcd_no_branch(), the rest was found by the ever so helpful grep(1). CID 345122 ok jsing