A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_9_BASE 2025-11-26T10:19:57+00:00 2025-11-26T10:19:57+00:00 tb 2025-11-26T10:19:57+00:00 urn:sha1:4879f73ba340a5a6a1e4b5812f046c92cf362d95 An upcoming change requires the inclusion of asn1_local.h in x509_local.h which doesn't work due to missing header guards. Add guards to all local headers that don't have them, although reacharounds and multiple inclusions are unlikely to occur for most of those. ok jsing 2025-01-05T15:39:12+00:00 tb 2025-01-05T15:39:12+00:00 urn:sha1:5c33a5ef4d95e91c63b215ad65de78c9bc54ff85 You can set custom sign and verify handlers on an RSA method (wihch is used to create RSA private and public key handles). However, even if you set them explicitly with RSA_meth_set_{sign,verify}(3), these handlers aren't used for the sake of "backward compatibility" (with what?). In order to use them, you need to opt your objects into using the custom methods you set by setting the RSA_FLAG_SIGN_VER flag. OpenSSL 1.1 dropped this requirement and therefore nobody sets this flag anyore. Like most of the mechanically added accessors, almost nothing uses them, but, as found by kn, the yubco-piv-tool does. This resulted in a public key being passed to rsa_private_encrypt(), which of course doesn't end well. So follow OpenSSL 1.1 and drop this muppetry. This makes kn's problem with yubico-piv-tool go away. ok jsing kn 2024-11-29T07:42:35+00:00 tb 2024-11-29T07:42:35+00:00 urn:sha1:916f80d01875d84154d09cf15bfc3c885c8c0b05 the weird thing it was supposed to be doing couldn't possibly work. ok jsing 2024-01-01T15:43:02+00:00 tb 2024-01-01T15:43:02+00:00 urn:sha1:47d1fa801e401851a63a646963373a1fc697be9f These aren't particularly helpful and should probably both be expanded. For now move them to the only place where they are actually used. 2023-11-29T21:35:57+00:00 tb 2023-11-29T21:35:57+00:00 urn:sha1:69bbc5fea4f411f0c0033ecb0fc5126c895ea82a This removes the remaining ENGINE members from various internal structs and functions. Any ENGINE passed into a public API is now completely ignored functions returning an ENGINE always return NULL. ok jsing 2023-08-09T12:09:06+00:00 tb 2023-08-09T12:09:06+00:00 urn:sha1:f6afd562e52c37d3b28855caea8e1d7b0cf643c5 Instead of CRYPTO_THREADID, which passes pthread_via through unsigned long, we can use pthread_self() and pthread_equal() directly. This commit keeps using the awkward 'local' nomenclature as that is used throughout the rsa code. This will be changed after the blinding code will have been fully merged into rsa_blinding.c. ok jsing 2023-08-09T09:23:03+00:00 tb 2023-08-09T09:23:03+00:00 urn:sha1:bfbc83aae49a28b991a404a75f049803aece30bf discussed with jsing 2023-07-28T10:05:16+00:00 tb 2023-07-28T10:05:16+00:00 urn:sha1:8f7aef795a81efc6cca2f7503141e0fddb4358c1 RSA is pretty bad. In my most optimistic moments I dream of a world that stopped using it. That won't happen during my lifetime, unfortunately. Blinding is one way of making it a little less leaky. Unfortunately this side-channel leak mitigation leaked out of the library for no good reason. Let's at least fix that aspect of it. ok jsing 2023-07-21T15:26:51+00:00 tb 2023-07-21T15:26:51+00:00 urn:sha1:1abe71c2dc0f7ac0bb94d085b67dfac7b28d3cb0 discussed with jsing 2023-05-05T12:21:44+00:00 tb 2023-05-05T12:21:44+00:00 urn:sha1:c167f76677a4e5f366fabdcac0782677114c0a66 This makes the custom stalt stack work again. Tested by robert as part of a larger diff ok jsing