openbsd/src/lib/libcrypto/rsa, branch libressl-v2.1.2 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v2.1.2 2014-10-22T13:02:04+00:00 Use arc4random_buf() instead of RAND_bytes() or RAND_pseudo_bytes(). 2014-10-22T13:02:04+00:00 jsing 2014-10-22T13:02:04+00:00 urn:sha1:fa457604779ff38b511fdfdae3c6a78664281c22 arc4random_buf() is guaranteed to always succeed - it is worth noting that a number of the replaced function calls were already missing return value checks. ok deraadt@ None of these need to include <openssl/rand.h> 2014-10-18T17:20:40+00:00 jsing 2014-10-18T17:20:40+00:00 urn:sha1:0bad55f54f7132a386746f23ba4f2d106d115563 Make sure all error conditions in RSA_padding_add_PKCS1_PSS_mgf1() cause 2014-07-13T12:53:46+00:00 miod 2014-07-13T12:53:46+00:00 urn:sha1:084ac7bb2b862c42ba3dc03ead646499ce571431 EVP_MD_CTX_cleanup() to be called. if (x) FOO_free(x) -> FOO_free(x). 2014-07-12T16:03:37+00:00 miod 2014-07-12T16:03:37+00:00 urn:sha1:068bf464df6ef084067943863d776f59762bfaf0 Improves readability, keeps the code smaller so that it is warmer in your cache. review & ok deraadt@ In RSA_eay_private_encrypt(), correctly return the smaller BN; OpenSSL 2014-07-11T15:21:51+00:00 miod 2014-07-11T15:21:51+00:00 urn:sha1:406373e1c997f9483fd931e40033662fbefb65fe PR #3418 via OpenSSL trunk Remove duplicate 0x for salt len in output; Martin Kaiser via OpenSSL trunk. 2014-07-11T12:59:10+00:00 miod 2014-07-11T12:59:10+00:00 urn:sha1:02ec539d99d59a03bacd90aa4e22e084d91830f0 Only import cryptlib.h in the four source files that actually need it. 2014-07-11T08:44:49+00:00 jsing 2014-07-11T08:44:49+00:00 urn:sha1:74e2c009c83ad374bd6acdcfc376a384e25ab007 Remove the openssl public includes from cryptlib.h and add a small number of includes into the source files that actually need them. While here, also sort/group/tidy the includes. ok beck@ miod@ Explicitly include <openssl/opensslconf.h> in every file that references 2014-07-10T22:45:58+00:00 jsing 2014-07-10T22:45:58+00:00 urn:sha1:62348213609ef233110561d1a6ed67ad66df1c7e an OPENSSL_NO_* define. This avoids relying on something else pulling it in for us, plus it fixes several cases where the #ifndef OPENSSL_NO_XYZ is never going to do anything, since OPENSSL_NO_XYZ will never defined, due to the fact that opensslconf.h has not been included. This also includes some miscellaneous sorting/tidying of headers. Stop including standard headers via cryptlib.h - pull in the headers that 2014-07-10T13:58:23+00:00 jsing 2014-07-10T13:58:23+00:00 urn:sha1:c917c683bc93c68fbf4310ac181f7906e76b3c94 are needed in the source files that actually require them. ok beck@ miod@ RSA_setup_blinding() gets a BN with BN_CTX_get(), returns `out of memory' 2014-07-10T12:36:58+00:00 miod 2014-07-10T12:36:58+00:00 urn:sha1:01835c580bc891d6c335f7dbe03b98ad207ba4ac if it fails, then never uses it anymore, and may invoke a function which needs more than one BN from the BN_CTX anyway, so this is pointless - remove the BN_CTX_get() call and the test. ok jsing