openbsd/src/lib/libcrypto/rsa, branch libressl-v2.1.4 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v2.1.4 2015-02-15T14:35:30+00:00 Regen 2015-02-15T14:35:30+00:00 miod 2015-02-15T14:35:30+00:00 urn:sha1:abd73a522ddcc1102ca86cc090873f4547b8bb41 Check for allocation error in RSA_eay_mod_exp(). Coverity CID 25217. 2015-02-14T15:10:39+00:00 miod 2015-02-14T15:10:39+00:00 urn:sha1:4ab76f0bb67518cfef60408ecb681f93c3fe9a67 ok jsing@ Expand ASN1_CHOICE*, ASN1_SEQUENCE* and associated macros, making the 2015-02-14T15:06:55+00:00 jsing 2015-02-14T15:06:55+00:00 urn:sha1:50c0f75baaf19556bde13d9ac8eeac270daa913b data structures visible and easier to review, without having to wade through layers and layers of asn1t.h macros. Change has been scripted and there is no change to the generated assembly. Discussed with beck@ miod@ tedu@ Guenther has plans for OPENSSL_NO_CMS, so revert this for the moment. 2015-02-11T04:05:14+00:00 beck 2015-02-11T04:05:14+00:00 urn:sha1:3fb89787679dd239a55ca0a4e366ad4e2051fe84 get rid of OPENSSL_NO_CMS code we do not use. 2015-02-11T03:55:42+00:00 beck 2015-02-11T03:55:42+00:00 urn:sha1:1d3b395bb02124e944ce4abc2f2eab59e2cde925 ok miod@ Enable building with -DOPENSSL_NO_DEPRECATED. 2015-02-11T03:19:37+00:00 doug 2015-02-11T03:19:37+00:00 urn:sha1:e816a1ec1d4411707051912b945e8eab7a5a94e8 If you didn't enable deprecated code, there were missing err.h and bn.h includes. This commit allows building with or without deprecated code. This was not derived from an OpenSSL commit. However, they recently enabled OPENSSL_NO_DEPRECATED in git and fixed these header problems in a different way. Verified with clang that this only changes line numbers in the generated asm. ok miod@ Expand the -IMPLEMENT_ASN1_ENCODE_FUNCTIONS_(const_)?fname macros so that 2015-02-10T05:12:23+00:00 jsing 2015-02-10T05:12:23+00:00 urn:sha1:2bd884004b68a3cdb5e24f3a1e6e8e3baa60a43e the code is visible and functions can be readily located. Change has been scripted and there is no change to the generated assembly. Discussed with beck@ miod@ tedu@ Expand the IMPLEMENT_ASN1_FUNCTIONS macro so that the code is visible and 2015-02-09T16:04:46+00:00 jsing 2015-02-09T16:04:46+00:00 urn:sha1:4fb19543f9f5f3b5e26820a0dfdffa75a332314d functions can be readily located. Change has been scripted and there is no change to the generated assembly. Discussed with beck@ miod@ tedu@ BN_CTX_get() can fail - consistently check its return value. 2015-02-09T15:49:22+00:00 jsing 2015-02-09T15:49:22+00:00 urn:sha1:15dc63f9715f4f10924a705d6a4cc564afe2129e There are currently cases where the return from each call is checked, the return from only the last call is checked and cases where it is not checked at all (including code in bn, ec and engine). Checking the last return value is valid as once the function fails it will continue to return NULL. However, in order to be consistent check each call with the same idiom. This makes it easy to verify. Note there are still a handful of cases that do not follow the idiom - these will be handled separately. ok beck@ doug@ Use arc4random_buf() instead of RAND_bytes() or RAND_pseudo_bytes(). 2014-10-22T13:02:04+00:00 jsing 2014-10-22T13:02:04+00:00 urn:sha1:fa457604779ff38b511fdfdae3c6a78664281c22 arc4random_buf() is guaranteed to always succeed - it is worth noting that a number of the replaced function calls were already missing return value checks. ok deraadt@