A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_9 2025-02-14T12:01:58+00:00 2025-02-14T12:01:58+00:00 jsing 2025-02-14T12:01:58+00:00 urn:sha1:a89810379a758c9cd27af2462547dc646dcfaa61 Currently, SHA{1,256,512}_ASM defines are used to remove the C implementation of sha{1,256,512}_block_data_order() when it is provided by assembly. However, this prevents the C implementation from being used as a fallback. Rename the C sha*_block_data_order() to sha*_block_generic() and provide a sha*_block_data_order() that calls sha*_block_generic(). Replace the Makefile based SHA*_ASM defines with two HAVE_SHA_* defines that allow these functions to be compiled in or removed, such that machine specific verisons can be provided. This should effectively be a no-op on any platform that defined SHA{1,256,512}_ASM. ok tb@ 2024-06-01T07:36:17+00:00 tb 2024-06-01T07:36:17+00:00 urn:sha1:0cd26255605cab2a8643bb8585c4148069240e3c HMAC() and the one-step digests used to support passing a NULL buffer and would return the digest in a static buffer. This design is firmly from the nineties, not thread safe and it saves callers a single line. The few ports that used to rely this were fixed with patches sent to non-hostile (and non-dead) upstreams. It's early enough in the release cycle that remaining uses hidden from the compiler should be caught, at least the ones that matter. There won't be that many since BoringSSL removed this feature in 2017. https://boringssl-review.googlesource.com/14528 Add non-null attributes to the headers and add a few missing bounded attributes. ok beck jsing 2024-03-28T04:23:02+00:00 jsing 2024-03-28T04:23:02+00:00 urn:sha1:315693de05b08c3f051a52e78d7a801d8025ee4e 2023-08-11T15:27:28+00:00 jsing 2023-08-11T15:27:28+00:00 urn:sha1:2ea556a1c666b7176ccef64d78e376f1bfabef7c Now that we're no longer dependent on md32_common.h, stop including it. Remove various defines that only existed for md32_common.h usage. 2023-08-11T15:25:36+00:00 jsing 2023-08-11T15:25:36+00:00 urn:sha1:e5c37e5e9f9d7f447090e5f144afac1bcc9341d9 Replace macros with static inline functions, as well as writing out the variable rotations instead of trying to outsmart the compiler. Also pull the message schedule update up and complete it prior to commencement of the round. Also use rotate right, rather than transposed rotate left. Overall this is more readable and more closely follows the specification. On some platforms (e.g. aarch64) there is no noteable change in performance, while on others there is a significant improvement (more than 25% on arm). ok miod@ tb@ 2023-08-10T07:15:23+00:00 jsing 2023-08-10T07:15:23+00:00 urn:sha1:13ecebf7d6c58d65f6df008731bbb41f4c2be2f6 This is a hack that is only enabled on a handful of 64 bit platforms, as a workaround for poor compiler optimisation. If you're running an archiac compiler on an archiac architecture, then you can deal with slightly lower performance. ok tb@ 2023-07-08T12:24:10+00:00 beck 2023-07-08T12:24:10+00:00 urn:sha1:f46ac389a5f2c573c854a6c2b50156ca974ea892 ok tb@ 2023-07-07T15:06:50+00:00 jsing 2023-07-07T15:06:50+00:00 urn:sha1:fde51cb4e2939ec0bb618d4f3d036d65f9d10fb0 If input data is 32 bit aligned use be32toh() directly, otherwise use crypto_load_be32toh(), cleaning up all of the HOST_c2l() usage. ok beck@ 2023-07-07T15:03:55+00:00 jsing 2023-07-07T15:03:55+00:00 urn:sha1:44be04de359e261a9500ecf15cdd8379adbbbb9c Avoid reach around and initialisation outside of the macro, cleaning up the call sites to remove the initialisation. ok beck@ 2023-07-07T14:32:41+00:00 jsing 2023-07-07T14:32:41+00:00 urn:sha1:94d3e66bc0e7a75b697c3f80aa4dc9abb31d00dd ok beck@