openbsd/src/lib/libcrypto/srp, branch libressl-v2.1.2 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v2.1.2 2014-07-28T17:57:18+00:00 Remove SRP code. It contains a bug (this should not surprise anyone), but 2014-07-28T17:57:18+00:00 tedu 2014-07-28T17:57:18+00:00 urn:sha1:b63eafac49ed0f1d07ded42d6190c3f2fbcc71af the details are under embargo. The original plan was to wait for the embargo to lift, but we've been waiting for quite some time, and there's no indication of when or even if it will end. No sense in dragging this out any longer. The SRP code has never been enabled in OpenBSD, though I understand it is in use by some other people. However, in light of this and other issues, we're officially saying SRP is outside the scope of libressl. (For now.) Kill a bunch more BUF_strdup's - these are converted to have a check for 2014-07-22T02:21:20+00:00 beck 2014-07-22T02:21:20+00:00 urn:sha1:de26b5621b74df2934238e0cedd549c31c9c6a32 NULL before an intrinsic strdup. ok miod@ The bell tolls for BUF_strdup - Start the migration to using 2014-07-13T16:03:10+00:00 beck 2014-07-13T16:03:10+00:00 urn:sha1:c7e9c2c6576cd5406680f9b69aff2038ba63b0dc intrinsics. This is the easy ones, a few left to check one at a time. ok miod@ deraadt@ Only import cryptlib.h in the four source files that actually need it. 2014-07-11T08:44:49+00:00 jsing 2014-07-11T08:44:49+00:00 urn:sha1:74e2c009c83ad374bd6acdcfc376a384e25ab007 Remove the openssl public includes from cryptlib.h and add a small number of includes into the source files that actually need them. While here, also sort/group/tidy the includes. ok beck@ miod@ Explicitly include <openssl/opensslconf.h> in every file that references 2014-07-10T22:45:58+00:00 jsing 2014-07-10T22:45:58+00:00 urn:sha1:62348213609ef233110561d1a6ed67ad66df1c7e an OPENSSL_NO_* define. This avoids relying on something else pulling it in for us, plus it fixes several cases where the #ifndef OPENSSL_NO_XYZ is never going to do anything, since OPENSSL_NO_XYZ will never defined, due to the fact that opensslconf.h has not been included. This also includes some miscellaneous sorting/tidying of headers. Make sure srp_Calc_k() digest operations are checked for error; from 2014-07-10T20:22:00+00:00 miod 2014-07-10T20:22:00+00:00 urn:sha1:d12d359cc5baaa581594b788746b1cd6812ee01f Florian Zumbiehl (florz , florz . de) on tech@ Make sure SRP_Calc_client_key() returns NULL instead of a pristine BN_new() 2014-07-10T20:18:51+00:00 miod 2014-07-10T20:18:51+00:00 urn:sha1:cc7bb421a0a43a8e4b8f5293381576691d42f355 upon error; from Florian Zumbiehl (florz , florz . de) on tech@ tags as requested by miod and tedu 2014-06-12T15:49:31+00:00 deraadt 2014-06-12T15:49:31+00:00 urn:sha1:59f4f2c61d71e266d37dd2fc97615b3fd35b4721 malloc() result does not need a cast. 2014-06-07T14:41:57+00:00 deraadt 2014-06-07T14:41:57+00:00 urn:sha1:800fbde652d67326eeb163d56d8f72ebb239b3c4 ok miod convert 53 malloc(a*b) to reallocarray(NULL, a, b). that is 53 2014-05-29T21:07:43+00:00 deraadt 2014-05-29T21:07:43+00:00 urn:sha1:642d45ae22413aa8195b105d051ca8896e782c5d potential integer overflows easily changed into an allocation return of NULL, with errno nicely set if need be. checks for an allocations returning NULL are commonplace, or if the object is dereferenced (quite normal) will result in a nice fault which can be detected & repaired properly. ok tedu